Skip to content

Commit a6db017

Browse files
authored
Fix panic updating tags during adoption (#172)
Issue #, if available: [2621](aws-controllers-k8s/community#2621) Description of changes: - Retrieve resource ARN from latest instead of desired to avoid panic. Desired ARN is not populated on first update when adopting. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent ce94cae commit a6db017

File tree

11 files changed

+45
-42
lines changed

11 files changed

+45
-42
lines changed

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2025-08-15T00:01:38Z"
3-
build_hash: b6df33f8c7f55b234555c0b578b8de43c74771a8
4-
go_version: go1.24.6
5-
version: v0.51.0
2+
build_date: "2025-09-15T20:18:06Z"
3+
build_hash: 9e29f017d9e942548af133d2f31aecae248a8816
4+
go_version: go1.25.0
5+
version: v0.51.0-3-g9e29f01
66
api_directory_checksum: 2b5e65a1d5f0a032d51209f925b714aff4b6dc96
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.37.0

helm/templates/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ metadata:
1010
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
1111
k8s-app: {{ include "ack-eks-controller.app.name" . }}
1212
helm.sh/chart: {{ include "ack-eks-controller.chart.name-version" . }}
13+
{{- range $key, $value := .Values.deployment.labels }}
14+
{{ $key }}: {{ $value | quote }}
15+
{{- end }}
1316
spec:
1417
replicas: {{ .Values.deployment.replicas }}
1518
selector:

pkg/resource/access_entry/resource.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/addon/resource.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/addon/sdk.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/cluster/resource.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/fargate_profile/resource.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/identity_provider_config/resource.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/nodegroup/resource.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/pod_identity_association/resource.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)