Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Ability to tell if form is dirty when adding custom sign up fields #5754

Open
2 tasks
ben-claimable opened this issue Sep 5, 2024 · 2 comments
Open
2 tasks
Labels
feature-request Request a new feature pending-community-response Issue is pending response from the issue requestor or other community members

Comments

@ben-claimable
Copy link

ben-claimable commented Sep 5, 2024

On which framework/platform would you like to see this feature implemented?

React

Which UI component is this feature-request for?

Authenticator

Please describe your feature-request in detail.

We are implementing an "Agree to terms" checkbox on sign up following the example listed in your docs (https://ui.docs.amplify.aws/react/connected-components/authenticator/customization#sign-up-fields).

We noticed that the error message is showing up before the form is submitted, and we would like to have a way to only show the error message is the form is "dirty".

Please describe a solution you'd like.

No response

We love contributors! Is this something you'd be interested in working on?

  • 👋 I may be able to implement this feature request.
  • ⚠️ This feature might incur a breaking change.
@ben-claimable ben-claimable added the feature-request Request a new feature label Sep 5, 2024
@github-actions github-actions bot added the pending-triage Issue is pending triage label Sep 5, 2024
@thaddmt
Copy link
Member

thaddmt commented Sep 6, 2024

@ben-claimable do you have an example code or screenshot you can paste to help us figure out which particular fields you are concerned with?

The github link you posted gives a 404, maybe the repository is private?

@thaddmt thaddmt added pending-response and removed pending-triage Issue is pending triage labels Sep 6, 2024
@ben-claimable
Copy link
Author

Just edited with the correct link, sorry about that. For now we have decided to remove the error messages to get around this issue, but this feature would still be useful.

@jordanvn jordanvn added the pending-community-response Issue is pending response from the issue requestor or other community members label Sep 19, 2024
@calebpollman calebpollman changed the title Ability to tell if form is dirty when adding custom sign up fields [FR] Ability to tell if form is dirty when adding custom sign up fields Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature pending-community-response Issue is pending response from the issue requestor or other community members
Projects
None yet
Development

No branches or pull requests

5 participants
@cwomack @thaddmt @ben-claimable @jordanvn and others