Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): Allow retry if fetchAuthSession fails #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattcreaser
Copy link
Member

Issue #, if available:
#203

Description of changes:
If the initial fetchAuthSession fails during Authenticator startup, the resulting error will allow retry. See screenshot below.

Screenshot_20250218_154618

How did you test these changes?
Produced failure and verified behaviour.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners February 18, 2025 19:57
@mattcreaser
Copy link
Member Author

We need retry for getCurrentUser failure as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant