Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported fields from new ECS Panel #430

Open
GyllieGyllie opened this issue Dec 14, 2022 · 10 comments
Open

Unsupported fields from new ECS Panel #430

GyllieGyllie opened this issue Dec 14, 2022 · 10 comments

Comments

@GyllieGyllie
Copy link

GyllieGyllie commented Dec 14, 2022

If you are using the new ECS panel to create the original task definition you can now specify a port name & app protocol but both fields aren't supported by the code causing you to be unable to update it.

Error: Failed to register task definition in ECS: There were 2 validation errors:
UnexpectedParameter: Unexpected key 'name' found in params.containerDefinitions[0].portMappings[0]
UnexpectedParameter: Unexpected key 'appProtocol' found in params.containerDefinitions[0].portMappings[0]

We are using aws-actions/[email protected]

@abcfy2
Copy link

abcfy2 commented Dec 21, 2022

Seem issue here. Please fix this issue. Thanks.

Error: Failed to register task definition in ECS: Unexpected key 'appProtocol' found in params.containerDefinitions[0].portMappings[0]
Error: Unexpected key 'appProtocol' found in params.containerDefinitions[0].portMappings[0]

@Muhammad-Suleman-Amjad
Copy link

Until the issue is fixed, to let this work on new ECS console, we can delete these two fields i.e. name & appProtocol from container Definition part of json in task definition and it will start working.

@rockey5520
Copy link

I am too facing the same problem and wondering if there is a way to fix using Github action rather than adjusting it manually in the console.

@shinenelson
Copy link

duplicate of #426

@gruckion
Copy link

gruckion commented Jan 4, 2023

Work around for now is to switch to the old ECS experience and generate the task definition using that. Ensure you create it from the older task definition before the modification was made.

image

@CuriousLearner
Copy link

Hey folks 👋🏼

Any updates or plan on making a new release to handle the updated fields?

@GyllieGyllie
Copy link
Author

GyllieGyllie commented Jan 30, 2023

The new layout is indeed forced now on the panels so can't even use the workaround anymore to go back to the old panel. Only solution now is using the API to setup the first version

Seems like a PR is already open to fix this so someone just needs to review it: aws/aws-sdk-js#4310

@elvirag
Copy link

elvirag commented May 31, 2023

Please fix this, there's already a fix, I'm quite tired of seeing this in my workflow failures
Failed to register task definition in ECS: Unexpected key 'name' found in params.containerDefinitions[0].portMappings[0]

Who do I need to ask to get this merged?

@CuriousLearner
Copy link

Yes, this has been a problem for so long. If I manually change the config, the next deployment fails, until I remember to edit the JSON manually.

Please consider merging the fix. 🙏🏼

@dbcall2
Copy link

dbcall2 commented Sep 11, 2023

This really needs to be merged as ServiceConnect is completely unusable through the boto ecs task registration apis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants