Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential dependency conflicts between ambient-aprs and urllib3 #7

Open
NeolithEra opened this issue Dec 25, 2019 · 1 comment
Open

Comments

@NeolithEra
Copy link

NeolithEra commented Dec 25, 2019

Hi, as shown in the following full dependency graph of ambient-aprs, ambient-api requires urllib3 * , while the installed version of _requests _(2.22.0) requires urllib3 <1.26,>=1.21.1.

According to Pip's “first found wins” installation strategy, urllib3 1.25.7 is the actually installed version.

Although the first found package version urllib3 1.25.7 just satisfies the later dependency constraint (urllib3 <1.26,>=1.21.1), it will lead to a build failure once developers release a newer version of urllib3.

Dependency tree--------

ambient-aprs - 0.11.2
| +- ambient-api(install version:1.5.2 version range:*)
| | +- requests(install version:2.22.0 version range:*)
| | | +- certifi(install version:2019.11.28 version range:>=2017.4.17)
| | | +- chardet(install version:3.0.4 version range:<3.1.0,>=3.0.2)
| | | +- idna(install version:2.8 version range:>=2.5,<2.9)
| | | +- urllib3(install version:1.25.7 version range:<1.26,>=1.21.1)
| | +- urllib3(install version:1.25.7 version range:*)

Thanks for your attention.
Best,
Neolith

@NeolithEra
Copy link
Author

NeolithEra commented Dec 25, 2019

Suggested Solution

  1. Ask your upstream project ambient-api to fix his direct dependencies to be urllib3 <1.26.
  2. Ask your upstream project request to loose the version range of urllib3 to be >=1.21.1.

@avryhof Which solution do you prefer, 1 or 2?
Please let me know your choice. May I pull a request to solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant