-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More fork information? #2
Comments
Thank you for your detailed message. Appreciate this. I dropped from contributing to the chrishubert/whatsapp-api project since I don't right to accept my own PRs. You can find a few my PRs that left not merged to the main branch. Moreover, I'm using the project at my work, so fixing critical bugs and adding new functionality is crucial in my case. I just heard from Christophe that he doesn't have a free time to contribute to the project, this might change in the future, so I can't add the public message about sunsetting of the project. A few words about this repo, I was in rush adding new functionality and refactoring the project, so skipped the PR stage. This definitely will be changed for all upcoming changes and we won't have breaking changes without mentioning this in the release description. Stay tuned :) |
Thanks @avoylenko ! I've starred the repo and will continue to keep an eye on it. I appreciate the work you're doing. |
I love your job and I have starred your repo. keep continuing your great work |
Hello! The readme says:
I'm interested in your fork but it's difficult to tell what its differences and purposes are.
I don't see any public message in the original repo stating that it's abandoned, and the most recent PR merged was only a few months ago: chrishubert/whatsapp-api#246
Also it seems like it was merged by you (@avoylenko), so if you have commit rights on that project I wonder why you would not continue development there.
But more importantly, I see commits in this repo made directly to
main
without PRs, and no changelog or description of what's being changed. Some changes appear to be breaking but I'm not sure whether semver is being used or not either.If you're intending the fork to be used by others then having PRs with descriptions, changelogs, and consistent versioning would go a long way!
If the project is not really intended for public consumption that's useful info as well.
Thank you!
The text was updated successfully, but these errors were encountered: