Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location CSV upload with missing values #760

Closed
Tracked by #1588
BEULAHEVANJALIN opened this issue Jul 19, 2024 · 5 comments
Closed
Tracked by #1588

Location CSV upload with missing values #760

BEULAHEVANJALIN opened this issue Jul 19, 2024 · 5 comments
Assignees

Comments

@BEULAHEVANJALIN
Copy link

BEULAHEVANJALIN commented Jul 19, 2024

Describe the bug
The CSV upload did not handle missing values correctly. Uploaded the following csv.
image
This issue results in incorrect results in the ETL and lineage in the address_level table.
ETL table:
image

To Reproduce
Steps to reproduce the behavior:

  1. Upload a CSV as follows:
image
  1. Check the lineage

AC:

Lets say the complete location hierarchy is Block,GP,Village/Hamlet

What hierarchies should be allowed in the CSV: Refer this sheet for egs

The above is so that to allow setting location properties and geo-coordinates for locations at any level

What should not be allowed:

Lets say the complete location hierarchy is Block,Gram Panchayat,Village/Hamlet

  • For locations to be created, all higher locations in the location hierarchy of the location need to be mentioned. Refer this sheet for egs
  • Show errors as mentioned in the above CSV
  • Should not show error if locations across hierarchies are missing.
  • It is not necessary to mention the entire location hierarchy ie., Missing children are fine, Missing parents is what is not fine.
  • The above are applicable only for Location create mode CSV file
  • In the descriptor row of the create mode of CSV sample file mention as 'Mandatory to mention the parent locations to which the location to be created belongs to' like here

Testing:

Test with single and multiple hierarchies.

@mahalakshme
Copy link
Contributor

  • descriptor row -'Mandatory to mention the parent locations to which the location to be created belongs to' missing
  • sample location file has a empty column at the end

@himeshr
Copy link
Contributor

himeshr commented Sep 19, 2024

Code changes done in commit 74abd73 are in Master branch.

Attached sample file without required descriptor and missing Specific error msg info, required as per AC.

errors-locations-bl-apf_missing-children-invalid.csv
sample-locations-bl-apf.csv

@himeshr himeshr reopened this Sep 19, 2024
@himeshr
Copy link
Contributor

himeshr commented Sep 19, 2024

@1t5j0y
Copy link
Contributor

1t5j0y commented Sep 20, 2024

Commit was made to 10.0 itself but was not deployed to prerelease. Change has now been deployed. Please retest.

@himeshr
Copy link
Contributor

himeshr commented Sep 20, 2024

  • Previous testing failiure reasons have been resolved.

  • We do not have explicit details in Error message indicating which Parent Locations are missing.
    Mention 'Block' name to which 'GP1' belongs to

Should be good enough for now.

@himeshr himeshr closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

7 participants