Skip to content

Commit 10759c2

Browse files
committed
fixed bug when dumping greyscale data
dereferencing takes precedence over addition, so "*data+1" is really "data[0]+1" rather than data[1]. (incrementing has precedence over dereferencing, so "*data++" works as "data[0]; data++")
1 parent edb725e commit 10759c2

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/Pixes/pix_dump.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -271,12 +271,12 @@ void pix_dump :: trigger()
271271
while (datasize--) {
272272
if ( !m_bytemode ) {
273273
float v;
274-
v = static_cast<float>(*data) / 255.f; SETFLOAT(&m_buffer[i], v);
275-
v = static_cast<float>(*data+1) / 255.f; SETFLOAT(&m_buffer[i+1], v);
276-
v = static_cast<float>(*data+2) / 255.f; SETFLOAT(&m_buffer[i+2], v);
274+
v = static_cast<float>(data[0]) / 255.f; SETFLOAT(&m_buffer[i], v);
275+
v = static_cast<float>(data[1]) / 255.f; SETFLOAT(&m_buffer[i+1], v);
276+
v = static_cast<float>(data[2]) / 255.f; SETFLOAT(&m_buffer[i+2], v);
277277
i+=3;
278278
if ( m_mode == GL_RGBA ) {
279-
v = static_cast<float>(*data+3) / 255.f; SETFLOAT(&m_buffer[i], v);
279+
v = static_cast<float>(data[3]) / 255.f; SETFLOAT(&m_buffer[i], v);
280280
i++;
281281
}
282282
if ( m_doROI ){
@@ -287,12 +287,12 @@ void pix_dump :: trigger()
287287
}
288288
} else {
289289
unsigned char v;
290-
v = static_cast<unsigned char>(*data); SETFLOAT(&m_buffer[i], v);
291-
v = static_cast<unsigned char>(*data+1); SETFLOAT(&m_buffer[i+1], v);
292-
v = static_cast<unsigned char>(*data+2); SETFLOAT(&m_buffer[i+2], v);
290+
v = static_cast<unsigned char>(data[0]); SETFLOAT(&m_buffer[i], v);
291+
v = static_cast<unsigned char>(data[1]); SETFLOAT(&m_buffer[i+1], v);
292+
v = static_cast<unsigned char>(data[2]); SETFLOAT(&m_buffer[i+2], v);
293293
i+=3;
294294
if ( m_mode == GL_RGBA ) {
295-
v = static_cast<unsigned char>(*data+3); SETFLOAT(&m_buffer[i], v);
295+
v = static_cast<unsigned char>(data[3]); SETFLOAT(&m_buffer[i], v);
296296
i++;
297297
}
298298
if ( m_doROI ){

0 commit comments

Comments
 (0)