Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bench Elixir project into fast_rss? #5

Open
kianmeng opened this issue Nov 1, 2020 · 1 comment
Open

Move bench Elixir project into fast_rss? #5

kianmeng opened this issue Nov 1, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@kianmeng
Copy link
Contributor

kianmeng commented Nov 1, 2020 •
edited
Loading

I've noticed that bench was a total separate Elixir project within fast_rss. Is there a reason why it was implemented that way?

Is it possible to move benchmark Elixir project within bench folder into fast_rss project instead where all dependencies used for benchmark tagged for :bench environment?
@praveenperera
Copy link
Member

I'm not really sure why I did it that way to be honest. Would you like to do a PR?

@praveenperera praveenperera added the good first issue Good for newcomers label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kianmeng @praveenperera