diff --git a/app/assets/stylesheets/avalon/_modals.scss b/app/assets/stylesheets/avalon/_modals.scss index e865cc55d8..6ba97fa9cc 100644 --- a/app/assets/stylesheets/avalon/_modals.scss +++ b/app/assets/stylesheets/avalon/_modals.scss @@ -37,21 +37,25 @@ .special-access label { display: block; - - input, - select { - display: inline; - width: auto; - min-width: 300px; - } - p { margin: 10px 0 5px 0; } + input, + select, .twitter-typeahead { - width: auto; + width: fit-content; + min-width: 375px; } + + input.form-control.date-input { + width: fit-content; + min-width: 0; + } + } + + .special-access .d-flex { + gap: 0.5em; } } diff --git a/app/javascript/components/ReactButtonContainer.scss b/app/javascript/components/ReactButtonContainer.scss index 1dcd151890..1647ca63e4 100644 --- a/app/javascript/components/ReactButtonContainer.scss +++ b/app/javascript/components/ReactButtonContainer.scss @@ -23,7 +23,7 @@ } .modal-open .modal { - height: 100vh; + height: calc(100vh - 80px); overflow: scroll; } diff --git a/app/views/bookmarks/update_access_control.html.erb b/app/views/bookmarks/update_access_control.html.erb index e63eb8e4b8..06f16a4d42 100644 --- a/app/views/bookmarks/update_access_control.html.erb +++ b/app/views/bookmarks/update_access_control.html.erb @@ -74,51 +74,61 @@ Unless required by applicable law or agreed to in writing, software distributed Special Access <%= label_tag "user" do %> <%= render partial: "modules/tooltip", locals: { form: form, field: 'user', tooltip: t("access_control.user"), options: {display_label: t("access_control.userlabel").html_safe} } %> -
+
<%= hidden_field_tag "user" %> <%= text_field_tag "user_display", nil, class: "typeahead from-model form-control", - data: { model: 'user', target: "user" } %>
- <%= text_field_tag "add_user_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
+ data: { model: 'user', target: "user" } %> + <%= text_field_tag "add_user_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> <%= text_field_tag "add_user_end", nil, placeholder: 'End Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
- <%= button_tag "Add", name: 'submit_add_user', class:'btn btn-outline', value: 'Add' %> - <%= button_tag "Remove", name: 'submit_remove_user', class:'btn btn-outline remove_access', value: 'Remove' %> +
+ <%= button_tag "Add", name: 'submit_add_user', class:'btn btn-outline', value: 'Add' %> + <%= button_tag "Remove", name: 'submit_remove_user', class:'btn btn-outline remove_access', value: 'Remove' %> +
<% end %> <%= label_tag "group" do %> <%= render partial: "modules/tooltip", locals: { form: form, field: 'group', tooltip: t("access_control.group"), options: {display_label: t("access_control.grouplabel").html_safe} } %> - <% dropdown_values = [Admin::Group.non_system_groups, 'name', 'name'] %> - <% dropdown_values = options_from_collection_for_select(*dropdown_values) %> - <%= select_tag "group", - dropdown_values, - { include_blank: true, class: "form-control"}%>
- <%= text_field_tag "add_group_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
- <%= text_field_tag "add_group_end", nil, placeholder: 'End Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> - <%= button_tag "Add", name: 'submit_add_group', class:'btn btn-outline', value: 'Add' %> - <%= button_tag "Remove", name: 'submit_remove_group', class:'btn btn-outline remove_access', value: 'Remove' %> +
+ <% dropdown_values = [Admin::Group.non_system_groups, 'name', 'name'] %> + <% dropdown_values = options_from_collection_for_select(*dropdown_values) %> + <%= select_tag "group", + dropdown_values, + { include_blank: true, class: "form-control"}%> + <%= text_field_tag "add_group_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> + <%= text_field_tag "add_group_end", nil, placeholder: 'End Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> +
+
+ <%= button_tag "Add", name: 'submit_add_group', class:'btn btn-outline', value: 'Add' %> + <%= button_tag "Remove", name: 'submit_remove_group', class:'btn btn-outline remove_access', value: 'Remove' %> +
<% end %> <%= label_tag "class" do %> <%= render partial: "modules/tooltip", locals: { form: form, field: 'class', tooltip: t("access_control.class"), options: {display_label: t("access_control.classlabel").html_safe} } %> -
+
<%= hidden_field_tag "class" %> <%= text_field_tag "class_display", nil, class: "typeahead from-model form-control", - data: { model: 'externalGroup', target: "class" } %>
- <%= text_field_tag "add_class_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
+ data: { model: 'externalGroup', target: "class" } %> + <%= text_field_tag "add_class_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> <%= text_field_tag "add_class_end", nil, placeholder: 'End Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
- <%= button_tag "Add", name: 'submit_add_class', class:'btn btn-outline', value: 'Add' %> - <%= button_tag "Remove", name: 'submit_remove_class', class:'btn btn-outline remove_access', value: 'Remove' %> +
+ <%= button_tag "Add", name: 'submit_add_class', class:'btn btn-outline', value: 'Add' %> + <%= button_tag "Remove", name: 'submit_remove_class', class:'btn btn-outline remove_access', value: 'Remove' %> +
<% end %> <%= label_tag "ipaddress" do %> <%= render partial: "modules/tooltip", locals: { form: form, field: 'ipaddress', tooltip: t("access_control.ipaddress"), options: {display_label: t("access_control.ipaddresslabel").html_safe} } %> -
- <%= text_field_tag "ipaddress", nil, class: "form-control" %>
- <%= text_field_tag "add_ipaddress_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
+
+ <%= text_field_tag "ipaddress", nil, class: "form-control" %> + <%= text_field_tag "add_ipaddress_begin", nil, placeholder: 'Begin Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %> <%= text_field_tag "add_ipaddress_end", nil, placeholder: 'End Date (yyyy-mm-dd)', class: 'form-control date-input access_date', autocomplete: 'off' %>
- <%= button_tag "Add", name: 'submit_add_ipaddress', class:'btn btn-outline', value: 'Add' %> - <%= button_tag "Remove", name: 'submit_remove_ipaddress', class:'btn btn-outline remove_access', value: 'Remove' %> +
+ <%= button_tag "Add", name: 'submit_add_ipaddress', class:'btn btn-outline', value: 'Add' %> + <%= button_tag "Remove", name: 'submit_remove_ipaddress', class:'btn btn-outline remove_access', value: 'Remove' %> +
<% end %>