From 48c297a3eb653b17734e4b929dd6a793b6c0e783 Mon Sep 17 00:00:00 2001 From: Chris Colvard Date: Wed, 10 Jan 2024 14:46:30 -0500 Subject: [PATCH] Only return link html if website url present --- app/presenters/collection_presenter.rb | 2 +- spec/presenters/collection_presenter_spec.rb | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/app/presenters/collection_presenter.rb b/app/presenters/collection_presenter.rb index f8cc605413..27095f5904 100644 --- a/app/presenters/collection_presenter.rb +++ b/app/presenters/collection_presenter.rb @@ -52,7 +52,7 @@ def contact_email end def website_link - view_context.link_to document["website_label_ssi"], document["website_url_ssi"] unless document["website_url_ssi"].nil? + view_context.link_to document["website_label_ssi"], document["website_url_ssi"] if document["website_url_ssi"].present? end def as_json(_) diff --git a/spec/presenters/collection_presenter_spec.rb b/spec/presenters/collection_presenter_spec.rb index 37e7902c11..8967d9ccf6 100644 --- a/spec/presenters/collection_presenter_spec.rb +++ b/spec/presenters/collection_presenter_spec.rb @@ -86,6 +86,14 @@ expect(presenter.website_link).to be_nil end end + + context 'with a blank website url' do + let(:website_url) { '' } + + it 'returns null' do + expect(presenter.website_link).to be_nil + end + end end describe '#as_json' do