Skip to content

Conversation

@defitricks
Copy link

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature
  • Bugfix
  • Refactor
  • Format
  • Documentation
  • Testing
  • Other:

Description

While reviewing the code, I noticed that in the section where the value of the aarch variable is checked, quotes are missing in the if conditions.

The correct approach should include quotes around the variable to handle cases where aarch is empty, avoiding potential syntax errors:

if [ "$aarch" == "x86_64" ]
if [ "$aarch" == "aarch64" ]

This small adjustment ensures the script behaves reliably, even in edge cases.

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

… issues

Fix missing quotes in aarch variable checks to prevent potential issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant