This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Teleporter registry upgrade#43
Merged
minghinmatthewlam merged 95 commits intomainfrom Oct 30, 2023
Merged
Conversation
added 12 commits
August 26, 2023 06:02
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 6 commits
September 27, 2023 22:40
cam-schultz
previously approved these changes
Oct 26, 2023
Contributor
cam-schultz
left a comment
cam-schultz
left a comment
There was a problem hiding this comment.
LGTM! Thanks for creating the followup issues. Excited to get this merged 👍
minghinmatthewlam
dismissed stale reviews from geoff-vball and cam-schultz
via
a2d0d44
geoff-vball
previously approved these changes
Oct 27, 2023
cam-schultz
previously approved these changes
Oct 27, 2023
minghinmatthewlam
dismissed stale reviews from michaelkaplan13, cam-schultz, and geoff-vball
via
000a894
bernard-avalabs
previously approved these changes
Oct 30, 2023
| }) | ||
| ); | ||
| messageID = teleporterRegistry | ||
| .getLatestTeleporter() |
Contributor
There was a problem hiding this comment.
I just want to confirm that we never plan to send out blockhash using an older version of teleporter.
Author
There was a problem hiding this comment.
no don't think so, any particular use case you're thinking of?
Signed-off-by: minghinmatthewlam <matthew.lam@avalabs.org>
minghinmatthewlam
requested review from
bernard-avalabs,
cam-schultz and
michaelkaplan13
michaelkaplan13
approved these changes
Oct 30, 2023
| bridge_a_deploy_result=$(forge create --private-key $user_private_key --constructor-args $teleporter_contract_address \ | ||
| --rpc-url $subnet_a_url src/CrossChainApplications/ERC20Bridge/ERC20Bridge.sol:ERC20Bridge) | ||
| # Deploy the ERC20 bridge contract to all chains. | ||
| bridge_a_deploy_result=$(forge create --private-key $user_private_key \ |
Contributor
There was a problem hiding this comment.
Was there a need to move --constructor-args to be the last argument here with the last foundry version, or did you just move it to be consistent in our usage?
Author
There was a problem hiding this comment.
Was not due to last version, but on their page they say "The --constructor-args flag must be positioned last in the command, since it takes multiple values.", even though it seemed to work previously without being last position. https://book.getfoundry.sh/reference/forge/forge-create
cam-schultz
approved these changes
Oct 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Provides upgradeability of Teleporter through a registry contract #7. Creates a warp protocol registry that can be inherited by warp protocols, and for Teleporter specifically has
TeleporterRegistry.How this works
Adds a warp registry contract that gets inherited by
TeleporterRegistry. The registry can add new protocol versions through a warp out of band message, then keeps track of the version and protocol address mappings. The constructor of the registry also allows for initialization, so that the registry initially doesn't need an additional warp out of band message if Teleporter is already deployed.Cross chain apps will take in the registry instead of previous passing Teleporter in their constructor. The best practice for sending will be to ask the registry every time for sending with the latest version. For receiving, cross chain apps are recommended to have a
minTeleporterVersion, and for theirITeleporterReceiver.receiveTeleporterMessageimplementation to check that themsg.sendermatches aversion > _minTeleporterVersion.TeleporterUpgradeableprovides these best practices as an abstract contract that cross chain apps built on Teleporter can inherit and use.How this was tested
Unit Tests, adding tests for Teleporter/Warp registry and
TeleporterUpgradeableE2E test update to pass in registry for cross chain apps while warp out of band messages are still being implemented.
How is this documented
upgrade README