Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation: Store latest acked nonce #524

Open
cam-schultz opened this issue Sep 5, 2024 · 0 comments
Open

Delegation: Store latest acked nonce #524

cam-schultz opened this issue Sep 5, 2024 · 0 comments
Labels

Comments

@cam-schultz
Copy link
Contributor

Context and scope
We store the validator nonce used to start and end a delegation in the calls to initializeRegisterDelegator and initializeEndDelegation. In the complete step, we verify that the received nonce from the verified Warp message is greater than or equal to the stored nonce.

Rather than requiring a Warp message be verified when completing delegation registration/removal, we could track the latest received nonce in the contract's state, and skip the Warp message requirement if we've already received a higher nonce than the stored delegator nonce.

Open questions
We should quantify the gas savings this could yield, since we'd be increasing the amount of state stored in the contract.

@cam-schultz cam-schultz added the enhancement New feature or request label Sep 5, 2024
@cam-schultz cam-schultz added this to the Staking Manager - post MVP milestone Sep 5, 2024
@minghinmatthewlam minghinmatthewlam self-assigned this Sep 5, 2024
@minghinmatthewlam minghinmatthewlam removed their assignment Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

3 participants