sync: coreth PR #1303 style: Use require.ErrorIs whenever possible #1875
Conversation
| // "your custom test name": { | ||
| // Config: NewConfig(utils.NewUint64(3), {{- if .Contract.AllowList}} admins, enableds, managers{{- end}}), | ||
| // ExpectedError: ErrYourCustomError.Error(), | ||
| // WantError: ErrYourCustomError, |
There was a problem hiding this comment.
Will this break dependent users?
There was a problem hiding this comment.
If a user was using this template generation code and then doing a strings.Contains, then yeah I guess it would -- do we really care about that though? Is this supposed to be externally supported code? The fix is incredibly easy too -- just use errors.Is (as you're supposed to)
|
|
||
| var ErrCannotAddManagersBeforeDurango = errors.New("cannot add managers before Durango") | ||
| var ( | ||
| ErrAdminAndEnabledAddress = errors.New("cannot set address as both admin and enabled") |
There was a problem hiding this comment.
Do these all need exported?
There was a problem hiding this comment.
Yes they do -- I just tried for all of them. They're declared in package allowlist and used in package allowlist_test
| unpacked, err2 := UnpackSetFeeConfigInput(input, true) | ||
| if err != nil { | ||
| require.ErrorContains(t, err2, err.Error()) | ||
| require.Equal(t, err.Error(), err2.Error()) |
There was a problem hiding this comment.
The error chain are different, so ErrorIs fails.
Error: Target error should be in err chain:
expected: "invalid input length for fee config Input: 260"
in chain: "invalid input length for fee config Input: 260"
"invalid input length for fee config Input"
I didn't want to touch the old unpack config -- seems like it shouldn't be modified
|
|
||
| var ( | ||
| _ Backend = (*backend)(nil) | ||
| ErrValidateBlock = errors.New("failed to validate block message") |
There was a problem hiding this comment.
Why do these have to be exported?
There was a problem hiding this comment.
The errors are declared in package warp and used in package evm.
…r-1303-remaining-forbidigo
Syncs ava-labs/coreth#1303