Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Aug 7, 2025

This PR syncs:

Tthis PR brings in a lot of changes that aren't particular useful for subnet-evm, like the extender. This is intended, as I am trying to minimize the difference between coreth's version of these files, and subnet-evms. The eventual goal is the complete merger of all of these files, which is why I am making these changes now.

This PR introduces practically 0 "originally written by me code" - this is a culmination of the code of many other people (and in effect, has already been reviewed)

Also syncs this PR: ava-labs/coreth#1338 as surfaced by @alarso16

@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review August 8, 2025 21:13
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner August 8, 2025 21:13
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner August 11, 2025 14:53
@JonathanOppenheimer JonathanOppenheimer marked this pull request as draft October 14, 2025 18:48
@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review November 16, 2025 06:06
@JonathanOppenheimer JonathanOppenheimer marked this pull request as draft November 16, 2025 06:06
@JonathanOppenheimer
Copy link
Member Author

I was in the middle of reviewing but it seems this has some invalid and unrelated changes. It also is too big and it reverts some of previous PRs.

Can we focus on each of these sync PRs one-by-one maybe not mechanically but conceptually. A directy cherry-pick could be end up with massive conflicts.

This has been broken up significantly with 3 other PRs eating into this -- is this focused enough now?

@JonathanOppenheimer JonathanOppenheimer marked this pull request as ready for review November 17, 2025 17:08
@ceyonur ceyonur enabled auto-merge December 2, 2025 16:35
@ceyonur ceyonur added this pull request to the merge queue Dec 2, 2025
Merged via the queue into master with commit 50ef4ab Dec 2, 2025
13 checks passed
@ceyonur ceyonur deleted the sync-pr-963-atomic-sync-package branch December 2, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreth sync state-sync-migration Migration of state sync code to `avalanchego`.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants