Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node structure improvements #664

Open
1 of 4 tasks
rkuris opened this issue Jun 10, 2024 · 0 comments
Open
1 of 4 tasks

Node structure improvements #664

rkuris opened this issue Jun 10, 2024 · 0 comments

Comments

@rkuris
Copy link
Collaborator

rkuris commented Jun 10, 2024

Tasks

  • BranchNode currently has children and children_hashes. It's impossible for a BranchNode to have a hash of a child but no child address, so perhaps this should be: children: [Option<(LinearAddress, Option<TrieHash>>; Self::MAX_CHILDREN] or something like that
  • Investigating removing the Box around BranchNode. This saves some memory but at the cost of some memory allocations during many code paths.
  • See if we can improve consuming LeafNode when converting it to a BranchNode
  • Investigate any other areas that we can avoid allocating memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant