Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes suggestion from devrel #617

Open
felipemadero opened this issue Jul 21, 2023 · 0 comments
Open

API changes suggestion from devrel #617

felipemadero opened this issue Jul 21, 2023 · 0 comments

Comments

@felipemadero
Copy link
Collaborator

felipemadero commented Jul 21, 2023

From @cgcardona

We should rename getsnapshotnames to listsnapshots to match the naming convention of listblockchains, listrpcs and listsubnets

In the POST body of v1/control/attachpeer we should change the key from nodeName to name to match the syntax of addnode, pausenode, removenode, restartnode, and resumenode.

Instead of this

{
    "nodeName":"{{node_name}}"
}

This

{
    "name":"{{node_name}}"
}

Same thing in sendoutboundmessage. Rename nodeName to name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant