Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): fix Dockerfile indent #5495

Merged
merged 1 commit into from
Nov 28, 2024
Merged

refactor(docker): fix Dockerfile indent #5495

merged 1 commit into from
Nov 28, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 27, 2024

Description

The relevant sections are indented with 4 spaces, while other sections are consistently indented with 2 spaces. This PR will standardize the indentation to 4 spaces.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 27, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Nov 27, 2024
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it has 2 spaces indentation ✅

@youtalk youtalk merged commit 2490899 into main Nov 28, 2024
41 checks passed
@youtalk youtalk deleted the fix-indent branch November 28, 2024 12:31
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 29, 2024
* feat(docker): inherit `autoware-base`  images (autowarefoundation#5492)

* change run

Signed-off-by: Yutaka Kondo <[email protected]>

* use autoware-base images

Signed-off-by: Yutaka Kondo <[email protected]>

* update health-check

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* update load-env

Signed-off-by: Yutaka Kondo <[email protected]>

* fix rebase

Signed-off-by: Yutaka Kondo <[email protected]>

* add build-args

Signed-off-by: Yutaka Kondo <[email protected]>

* fix hcl

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* chore(autoware.repos): fix `autoware.universe` and `autoware_launch` versions to `0.39.0` (autowarefoundation#5479)

* ci: update the pr template and add comment-on-pr workflow (autowarefoundation#5500)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(spell-check): switch the repository to autowarefoundation (autowarefoundation#5501)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* ci(pre-commit-ansible): autoupdate (autowarefoundation#5217)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>

* ci(spell-check-diff): add explicit dict-packages (autowarefoundation#5503)

Signed-off-by: M. Fatih Cırıt <[email protected]>

* refactor(docker): fix `Dockerfile` indent (autowarefoundation#5495)

fix indent

Signed-off-by: Yutaka Kondo <[email protected]>

* feat(docker): update cleanup scripts (autowarefoundation#5497)

* update cleanup scripts

Signed-off-by: Yutaka Kondo <[email protected]>

* revert to ubuntu-22.04

Signed-off-by: Yutaka Kondo <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>

* ci(sync-files): make use of sync-files-templates repo (autowarefoundation#5504)

Signed-off-by: M. Fatih Cırıt <[email protected]>

---------

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Co-authored-by: awf-autoware-bot[bot] <94889083+awf-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants