Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_adapi_msgs to nightly.repos #5466

Conversation

isamu-takagi
Copy link
Contributor

Description

To achieve the ideal phase in this comment, I added the autoware_adapi_msgs repository to autoware-nightly.repos and wrote a TODO comment to autoware.repos.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi requested review from youtalk and mitsudome-r and removed request for mitsudome-r November 21, 2024 05:13
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the discussion #5459 (comment)

@isamu-takagi isamu-takagi merged commit 4a479b1 into autowarefoundation:main Nov 21, 2024
17 checks passed
@isamu-takagi isamu-takagi deleted the feat/add-adapi-msgs-to-nightly branch November 21, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants