Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware.repos): change autoware_adapi_msgs version #5459

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 20, 2024

Description

Change autoware_adapi_msgs version to pre-release branch to evaluate features in the next release.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think autowarefoundation/autoware.universe#9420 is fine but this is not fine because we would like to maintain the autoware.repos stable.

@isamu-takagi
Copy link
Contributor Author

@youtalk The autoware.universe main branch depends on adapi_msgs main (or beta) branch. For example, after merging this PR, builds will fail if adapi_msgs is v1.3.0. If you want to fix the version of adapi_msgs, you should also fix the version of autoware.universe.

@youtalk
Copy link
Member

youtalk commented Nov 21, 2024

That would be a complicated problem. I think the following approach is needed.

#5435

@xmfcx Based on that way of thinking, we would also need to maintain two ansible directories, which we want to avoid. In that case, I think it would be better to separate the main branch for providing a stable version and the development branch for providing the nightly version.

The branch names in awf/autoware.universe are humble for the stable version and main for the nightly version, so aligning with that might make things less confusing.

@isamu-takagi
Copy link
Contributor Author

@youtalk So should I change it to the following?

repos autoware.universe autoware_adapi_msgs
autoware.repos humble v1.3.0
autoware-nightly.repos main main (beta/1.7.0)

@youtalk
Copy link
Member

youtalk commented Nov 21, 2024

That’s mostly correct. The version of autoware.universe in autoware.repos is planned to be fixed at 0.38.0 in #5435, but it’s still taking some time.

@youtalk
Copy link
Member

youtalk commented Nov 21, 2024

Current phase

repos autoware.universe autoware_adapi_msgs
autoware.repos main v1.3.0
autoware-nightly.repos main -

Transision phase

repos autoware.universe autoware_adapi_msgs
autoware.repos main beta/1.7.0
autoware-nightly.repos main main

Ideal phase

repos autoware.universe autoware_adapi_msgs
autoware.repos *.*.* *.*.*
autoware-nightly.repos main main

@youtalk youtalk merged commit 6ae172a into autowarefoundation:main Nov 21, 2024
18 checks passed
@isamu-takagi isamu-takagi deleted the feat/change-adapi-msgs-version-to-beta-1.7.0 branch November 21, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants