-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ad-api): add restrictions and options #602
Merged
isamu-takagi
merged 3 commits into
autowarefoundation:main
from
isamu-takagi:feat/adapi-add-restrictions-and-options
Oct 23, 2024
Merged
feat(ad-api): add restrictions and options #602
isamu-takagi
merged 3 commits into
autowarefoundation:main
from
isamu-takagi:feat/adapi-add-restrictions-and-options
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
isamu-takagi
requested review from
youtalk,
yuasabe,
yukkysaito,
sasakisasaki and
mitsudome-r
September 4, 2024 07:25
4 tasks
isamu-takagi
added
the
tag:deploy-docs
Mark for deploy-docs action generation. (used-by-ci)
label
Sep 4, 2024
youtalk
reviewed
Sep 5, 2024
4 tasks
youtalk
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add restrictions and options for safety. Related to autowarefoundation/autoware_adapi_msgs#61.
See the release notes for v1.6.0 for details.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.