docs(how-to-guides): add example procedure, case of localization #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: Shintaro Sakoda <[email protected]>
SakodaShintaro
force-pushed
the
add_how_to_guides_example_for_adding_new_node
branch
from
ce14249 to
2abb247
Compare
Signed-off-by: Shintaro Sakoda <[email protected]>
|
@mitsudome-r @kenji-miyake |
KYabuuchi
added
tag:deploy-docs
|
Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-410/ |
|
FYI: adding the label |
KYabuuchi
added
tag:deploy-docs
|
I will review today! I aplogize for the delay. 🙇 |
KYabuuchi
reviewed
Jul 14, 2023
There was a problem hiding this comment.
@SakodaShintaro Sorry for keeping you waiting. I have made some comments and suggestions, please check them out!
docs/how-to-guides/others/an-example-procedure-for-adding-a-new-node.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/an-example-procedure-for-adding-a-new-node.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/an-example-procedure-for-adding-a-new-node.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/an-example-procedure-for-adding-a-new-node.md
Outdated
Show resolved
Hide resolved
docs/how-to-guides/others/an-example-procedure-for-adding-a-new-node.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Shintaro SAKODA <[email protected]>
…in index.md Signed-off-by: Shintaro SAKODA <[email protected]>
|
@KYabuuchi |
KYabuuchi
reviewed
Jul 17, 2023
…w node" Signed-off-by: Shintaro SAKODA <[email protected]>
alanmengg
pushed a commit
to alanmengg/autoware-documentation
that referenced
this pull request
Aug 2, 2023
…owarefoundation#410) * add example procedure, case of localization Signed-off-by: Shintaro Sakoda <[email protected]> * style(pre-commit): autofix Signed-off-by: Shintaro Sakoda <[email protected]> * add language specifier Signed-off-by: Shintaro Sakoda <[email protected]> * Updated an-example-procedure-for-adding-and-evaluating-a-new-node.md Signed-off-by: Shintaro SAKODA <[email protected]> * Updated an-example-procedure-for-adding-and-evaluating-a-new-node.md in index.md Signed-off-by: Shintaro SAKODA <[email protected]> * Updated index of "An example procedure for adding and evaluating a new node" Signed-off-by: Shintaro SAKODA <[email protected]> --------- Signed-off-by: Shintaro Sakoda <[email protected]> Signed-off-by: Shintaro SAKODA <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: guiping meng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for #400, which add document about procedure of introducing a new node of localization.
The added pages leads to the necessary information rather than adding new information.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.