Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal API] user_priors, use_priors, disable_priors #110

Open
eddiebergman opened this issue Jul 2, 2024 · 2 comments
Open

[Internal API] user_priors, use_priors, disable_priors #110

eddiebergman opened this issue Jul 2, 2024 · 2 comments
Labels

Comments

@eddiebergman
Copy link
Contributor

eddiebergman commented Jul 2, 2024

Currently there are many functions taking in user_priors: bool, SuccessiveHalvinh/Hyperband + Sampling policy takes in user_priors: bool and BayesianOptimizer's use disable_priors.

We should just have one, use_priors: bool as it leads to inconsistencies in yaml files and definitions of various objects, even worse, one is a double negative, i.e. disable_priors = False which implies use_priors = True.

@Neeratyoy

@eddiebergman eddiebergman added the ux label Jul 2, 2024
@Neeratyoy
Copy link
Contributor

I agree.

There are 2 ways to tackle this:

@eddiebergman
Copy link
Contributor Author

I would vote for the first way, before the second one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants