Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-learn 1.0+ compatible release on PyPI #1371

Open
auvipy opened this issue Jan 18, 2022 · 11 comments
Open

scikit-learn 1.0+ compatible release on PyPI #1371

auvipy opened this issue Jan 18, 2022 · 11 comments
Labels
enhancement A new improvement or feature

Comments

@auvipy
Copy link

auvipy commented Jan 18, 2022

I will be happy to contribute

@eddiebergman
Copy link
Contributor

Hello @auvipy

It's on our todo list once we get some other PR's that we are currently working on, if youd like to start, we would be very much appreciative.

Doing so would likely require a decent amount of work, more than just updating the requirements file. It would involve going through the changelog and updating each component as neccessary and updating any test values that would change. At that point, we have external tests that validate that autosklearn does not degrade performance on automlbenchmark which we would perform externally from github.

@mfeurer, do you ideas of what else would be required?

Best,
Eddie

@auvipy
Copy link
Author

auvipy commented Jan 18, 2022

ok i am also up for coding changes as well

@eddiebergman
Copy link
Contributor

Thanks @auvipy,

I'll help guide you along the way and answer questions so feel free to open a PR and continue discussion there!

Best,
Eddie

@mfeurer
Copy link
Contributor

mfeurer commented Jan 18, 2022

Hey @eddiebergman we could actually also try a more gradual path in which we first allow both scikit-learn version in parallel and update the individual components over time?

@eddiebergman eddiebergman added the enhancement A new improvement or feature label Jun 10, 2022
@Rattko
Copy link
Contributor

Rattko commented Oct 11, 2022

@mfeurer, @eddiebergman is there any timeline for this issue?

@auvipy
Copy link
Author

auvipy commented Jul 29, 2023

I'm willing to restart the effort

@eddiebergman
Copy link
Contributor

Hi @auvipy,

Please see #1677, this update will already include the updated scikit-learn :)

Best,
Eddie

@auvipy
Copy link
Author

auvipy commented Jul 31, 2023

the latest PyPI release still using old scikit-learn
image

@eddiebergman
Copy link
Contributor

Yes, it's not released yet, just saying that the refactored auto-sklearn will already use the latest scikit learn (once it's released)

@auvipy
Copy link
Author

auvipy commented Jul 31, 2023

are they work in progress? shouldn't we consider any external contribution to the the project in the time being?

@eddiebergman
Copy link
Contributor

We can, but we would hesitate actually encouraging it, as updating sklearn has already been done in the refactor and so has dropping Python 3.7.

Apologies for having it private as there are reasons outside our control for doing so until it is released. I will update the main issue once there is an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new improvement or feature
Projects
None yet
Development

No branches or pull requests

4 participants