Update a component

[eddiebergman]

The components part of our codebase was written sometime ago, with older sklearn versions and before python typing was production ready.

In general, some of these files need to be cleaned up. Mostly typing of parameters and functions, adding documentation a bout these parameters and finally double checking with scikit learn that there aren't some new or deprecated parameters we still use.

To go the extra mile, some standalone tests that tests these components would be useful. At the moment we have general tests that test all components but specific tests for each component to go along side would help with regard to two other long term issues, namely

• Improve some code coverage #1350
• Convert some unittest tests to pytest style #1351

We would appreciate anyone who would like to take a component and help upgrade auto-sklearn to a more modern python :) Please see the contribution guide if you'd like to get started

[souravsingh]

@eddiebergman Is this issue still open? I would like to take a stab at it.

[eddiebergman]

Hi @souravsingh,

Thanks for taking interest :)

In general, it would be good to have a lot of our components cleaned up and properly typed with Mypy. Along with this, it would be good to have a link to the scikit learn component it's implementing and to double check that the parameters are correct (with respect to the right scikit learn version). The NotImplementedErrors could also be updated to NotFittedError. There might be more things to update but I'm not entirely sure and any suggestions are also welcome :)

If we can do this for all of the classifiers, this would let us remove this ignore so we can run Mypy on more of the codebase.

Why? Because Mypy and typing lets us catch errors while developing, without having to run tests and having mypy ignore files is losing this ability.

Depending on your time, even a single component is appreciated and would help serve as a good example for anyone else wishing to contribute :)

Best,
Eddie

[souravsingh]

@eddiebergman Sure I will get started

[BryanEstrada003]

I would like to work on this issue, can I?

[Aditi840]

Heyy, is this issue still open

[eddiebergman]

Hey @Aditi840,

Not at the moment, please check out #1677