Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper limits on requirements #51

Open
NeoChaos12 opened this issue Oct 19, 2020 · 5 comments
Open

Upper limits on requirements #51

NeoChaos12 opened this issue Oct 19, 2020 · 5 comments

Comments

@NeoChaos12
Copy link
Collaborator

An upper limit on the requirements of various dependencies seems to be a very harsh constraint. Since most repositories tend to try and maintain backwards compatibility when releasing new versions, doing so only plays a role when major updates that break backwards-compatibility are made. Otherwise, this simply complicates setting up appropriate environments. It would thus be preferable to forego setting these upper limits unless issues have been reported.

NeoChaos12 added a commit to NeoChaos12/HPOBench that referenced this issue Oct 19, 2020
NeoChaos12 added a commit to NeoChaos12/HPOBench that referenced this issue Oct 19, 2020
@PhMueller
Copy link
Collaborator

I had problems with the pandas version in combination with the openml data loading for the xgboost or svm benchmark.

The data loading script from the benchmarks required an older OpenML version, which unfortunately requires an older pandas version (and doesn't work with the new ones.)

Have you tried it or found a fix for this issue?

@KEggensperger
Copy link
Contributor

I would even recommend fixing the versions since we use these extra_requirements to also build the containers which should not change over time. What do you think?

@PhMueller
Copy link
Collaborator

It is beyond question the cleanest way. 😅. But maybe it is easier to handle this in a separate Pull Request?

@KEggensperger
Copy link
Contributor

Yes, agreed. We should fix the dependencies (at least for building container) in a separate PR.

Regarding removing the upper limit on the pandas versionf for the local version: Since there might be issues with loading data from openml, let's wait for the next python openml release which is scheduled next week and re-discuss the dependencies then.

@NeoChaos12
Copy link
Collaborator Author

NeoChaos12 commented Oct 23, 2020

I have actually wanted to know for months if you actually encountered issues with the higher versions, since I've been using using python>=3.8.3 and higher pandas versions for a while. They go hand-in-hand, as there seem to be some dependency conflicts between the python and pandas versions as well. Let's wait for the openml update though.

Should we consider having a "developer" set of requirements that is more flexible but carries fewer guarantees?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants