Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorder doesn't allow dict configs even though signature says so #89

Open
TheEimer opened this issue Nov 1, 2023 · 1 comment · Fixed by #94
Open

Recorder doesn't allow dict configs even though signature says so #89

TheEimer opened this issue Nov 1, 2023 · 1 comment · Fixed by #94
Assignees
Labels
invalid This doesn't seem right

Comments

@TheEimer
Copy link

TheEimer commented Nov 1, 2023

Because the ID is used as a dict key, the config can't be a dictonary in the recorder. Typing says otherwise and the error isn't very clear, this should be checked and also dict removed from the types.

@TheEimer TheEimer added the invalid This doesn't seem right label Nov 1, 2023
@KrissiHub
Copy link
Collaborator

I deleted the Type Hint in the signature, indicating that is if fine if the config is a dict (in the bug/pre-commit branch).
It only accepts Configurations now.

@helegraf helegraf linked a pull request Nov 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants