Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Dependencies shows only vertical line for certain cases #143

Closed
sarah-segel opened this issue May 8, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sarah-segel
Copy link
Collaborator

For example, using the run SMAC3v2/mlp-nondeterministic/run_1 with hyperparameter n_layer, only this is shown:

newplot (30)

@sarah-segel sarah-segel added the bug Something isn't working label May 8, 2024
@sarah-segel sarah-segel added this to the v2.0 milestone May 8, 2024
@helegraf helegraf self-assigned this Jun 14, 2024
@helegraf
Copy link
Contributor

I was already ready to give up with this but I finally found the cause of the bug:

PDP plots work exactly in the case that all the hyperparameters in the original ConfigSpace are sorted in an alphabetical order. Why? Because the PDP library copies the ConfigSpace with its own utility function, which gives the Hyperparameters new IDs, thus varying the wrong Hyperparameter, and DeepCAVE of course uses the IDs from the original ConfigSpace.

We should then probably create a bug report in the PDP repo but intermediate a fix on our side should be possible.

@sarah-segel
Copy link
Collaborator Author

Closed as it is a duplicate of #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants