Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Ordinal Hyperparameter got Key Error when run self.get_order in get_neighbors #344

Open
junhongmit opened this issue Nov 29, 2023 · 1 comment · May be fixed by #346
Open

[Bug] Ordinal Hyperparameter got Key Error when run self.get_order in get_neighbors #344

junhongmit opened this issue Nov 29, 2023 · 1 comment · May be fixed by #346

Comments

@junhongmit
Copy link

junhongmit commented Nov 29, 2023

image
In the get_neighbors function, the value passed into the self.get_order(value) is in the vector format (raw sequence order number). But the get_order() method returns self.value_dict[value], which is supposed to take the ordinal name.

One potential way to fix this is just to change line 270 to be if transform == False:, which reverse the transform logic.

@eddiebergman
Copy link
Contributor

Hiyo, this has been fixed in #346 which has a different implementation for get_neighbors now!
Hopefully released next week!

@eddiebergman eddiebergman linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants