Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with volume-stoichiometry regularisation scheme #337

Open
nfragapane opened this issue Feb 4, 2025 · 7 comments
Open

Issue with volume-stoichiometry regularisation scheme #337

nfragapane opened this issue Feb 4, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@nfragapane
Copy link
Collaborator

Image
Using volume-stoichiometry regularisation scheme for a RSS workflow gives me this error. Haven't seen this before using linear-hull scheme?

@nfragapane nfragapane changed the title Issue with volume-stoichiometry data preprocessing scheme Issue with volume-stoichiometry regularisation scheme Feb 4, 2025
@nfragapane nfragapane added the bug Something isn't working label Feb 4, 2025
@JaGeo
Copy link
Collaborator

JaGeo commented Feb 4, 2025

@nfragapane Thank you!

what autoplex version are you running? Have you been using the branch in #307?

@nfragapane
Copy link
Collaborator Author

No, the original 0.0.7 used for the paper

@JaGeo
Copy link
Collaborator

JaGeo commented Feb 4, 2025

Please talk to @YuanbinLiu about this as I haven't tested this specific version for producing data. We have only discovered a bug in subsequent versions.

@YuanbinLiu
Copy link
Collaborator

@nfragapane, the linear-hull scheme is applicable to all systems. As for the volume-stoichiometry regularization scheme, we have tested it on binary systems with different stoichiometries, and it has worked well. But we have not specifically tested it on non-stoichiometric ternary systems. Thank you for reporting this issue, and we will look into it.

@YuanbinLiu
Copy link
Collaborator

@nfragapane, the problem occurs because different structures return a different number of mole fraction components. For example, a two-element system returns a scalar while a three-element system returns an array of length 2. This discrepancy leads to errors when concatenating these values with volume and energy into a uniform array. In this context, one needs to pass element_order in label_stoichiometry_volume to return all element fractions. Currently, label_stoichiometry_volume only supports 3D convex hull calculations. Since we haven't tested whether regularization remains valid for three-component non-stoichiometric systems, more testing is needed. However, on the coding side, we can implement this using calculate_hull_nd in autoplex. A new PR will be initiated for this.

@JaGeo
Copy link
Collaborator

JaGeo commented Mar 3, 2025

@YuanbinLiu Thank you! We are looking forward to the PR.

@YuanbinLiu
Copy link
Collaborator

YuanbinLiu commented Mar 7, 2025

The PR is pushed. I think the issue has been fixed. See #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants