Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same default port for the HTTP API across serve and serve-testing #1748

Closed
torbenw opened this issue Feb 20, 2024 · 3 comments
Closed
Labels
kind/bug Something is broken or regressed

Comments

@torbenw
Copy link
Contributor

torbenw commented Feb 20, 2024

What platforms are affected?

linux, macos, windows

What architectures are affected?

amd64, arm64

What SpiceDB version are you using?

v1.29.1

Steps to Reproduce

  1. Start SpiceDB with serve --http-enabled and look for http server started serving in the output.
  2. Start SpiceDB with serve-testing --http-enabled and look for http server started serving in the output.

Expected Result

The port for the HTTP API should be the same for serve and serve-testing.

Actual Result

serve starts an HTTP server on port 8443:
{"level":"info","addr":":8443","service":"http","insecure":true,"time":"2024-02-20T17:51:01Z","message":"http server started serving"}

serve-testing starts an HTTP sever on port 8081:
{"level":"info","addr":":8081","service":"http","insecure":true,"time":"2024-02-20T18:03:23Z","message":"http server started serving"}

@torbenw torbenw added the kind/bug Something is broken or regressed label Feb 20, 2024
@josephschorr
Copy link
Member

@torbenw Should be a fairly small change on serve-testing; mind issuing a PR?

@torbenw
Copy link
Contributor Author

torbenw commented Feb 20, 2024

I've created pull request #1749 and changed 2 ports for serve-testing:
8081 -> 8443
8082 -> 8444

Now this should be equal to the ports of serve (but I did not test my changes, because I don't have anything set up for Go).

@josephschorr
Copy link
Member

Fixed by #1749. Thanks @torbenw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken or regressed
Projects
None yet
Development

No branches or pull requests

2 participants