Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationParameters.nonce is discarded. #622

Open
6 tasks done
timvanoostrom opened this issue May 29, 2024 · 0 comments
Open
6 tasks done

AuthorizationParameters.nonce is discarded. #622

timvanoostrom opened this issue May 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@timvanoostrom
Copy link

Checklist

Description

I'm not entirely sure if it's a bug in the interface or in the application code or part of functionality that I don't understand yet but here goes:

The nonce option in LoginOptions.authorizationParams interface is not used in auth_verification cookie. See also: https://github.com/auth0/express-openid-connect/blob/master/lib/context.js#L245-L258 and https://github.com/auth0/express-openid-connect/blob/master/lib/context.js#L286

If not used in the cookie, where is it for?

Reproduction

  1. Use own login route
  2. Provide authorizationParams.nonce value
  3. Inspect auth_verification cookie
res.oidc.login({
  authorizationParams: { nonce: 'test-nonce' },
});

Additional context

No response

express-openid-connect version

2.17.1

Express version

4.18.3

Node.js version

v21.7.3

@timvanoostrom timvanoostrom added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant