Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword replacement logic doesn't preserve items within emailProvider.credentials #846

Open
6 tasks done
brendenpalmer opened this issue Aug 24, 2023 · 0 comments
Open
6 tasks done
Labels

Comments

@brendenpalmer
Copy link
Contributor

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have upgraded to the latest version of this tool and the issue still persists.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

Keywords within emailProvider.credentials don't seem to be preserved on export. Because credentials aren't returned when retrieving remote assets, the keyword replacement logic can't find the property on the remote assets object src/keywordPreservation.ts#L202. As a result it's never updated/set on this object and the keyword isn't preserved.

Expectation

Should have keywords preserved within emailProvider.credentials

Reproduction

See failing test-case here: https://github.com/auth0/auth0-deploy-cli/compare/master...brendenpalmer:email-provider-credentials-failing-test-case?expand=1

Deploy CLI version

7.19.0

Node version

19.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant