Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions prior to 2.4.0 (namely the previous one 2.3.2) are not compatible with iOS 12 anymore #780

Closed
5 tasks done
Liquidsoul opened this issue Jun 19, 2023 · 2 comments
Closed
5 tasks done
Labels
feature request A feature has been asked for or suggested by the community

Comments

@Liquidsoul
Copy link

Liquidsoul commented Jun 19, 2023

Checklist

  • I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

When using the library with a version supporting iOS 12 (in my case the 2.3.2), the transitive dependencies JWTDecode and SimpleKeyChain are updated to their latest minor versions that do not support iOS 12.

This breaks the iOS 12 support entirely.

Describe the ideal solution

Auth0 uses the "upToNextMajor" versions of JWTDecode and SimpleKeychain in its released versions prior to 2.4.0.

As a consequence, the drop of iOS 12 should have triggered a major version bump of JWTDecode and SimpleKeychanin.

A new version 3.x of JWTDecode should revert the drop of iOS 12 and the drop should be integrated in a 4.x version.
A new version 1.x of SimpleKeychain should revert the drop of iOS 12 and the drop should be integrated in a 2.x version.

Alternatives and current workarounds

A workaround consists in adding explicitly the 2 dependencies to the project alongside the Auth0 dependency. However, this requires clients to maintain this dependency graph to match the future Auth0 updates which is not ideal.

Additional context

Sorry for filling this as a feature, I could not find a way to create a "bug" report.

@Liquidsoul Liquidsoul added the feature request A feature has been asked for or suggested by the community label Jun 19, 2023
@Widcket
Copy link
Contributor

Widcket commented Jun 20, 2023

Hi @Liquidsoul, thanks for raising this.

Auth0.swift, SimpleKeychain and JWTDecode.swift all share the same Support Policy (see their READMEs).

Screenshot 2023-06-20 at 11 19 31 PM

As per the Support Policy, they've been updated to drop support for iOS 12, and this was done in a minor version –which is not considered a breaking change.

Sorry for filling this as a feature, I could not find a way to create a "bug" report.

Thanks for mentioning this, turns out there was a problem with our Bug Report template: #781

@Widcket
Copy link
Contributor

Widcket commented Jun 21, 2023

Closing, as I believe the above answers your question.

@Widcket Widcket closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature has been asked for or suggested by the community
Projects
None yet
Development

No branches or pull requests

2 participants