Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more objects for defining searches #51

Open
dchaddock opened this issue Jan 7, 2022 · 1 comment
Open

Add more objects for defining searches #51

dchaddock opened this issue Jan 7, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@dchaddock
Copy link
Contributor

For all searches, we can add some more objects to help define the search parameters. This would include:

  • ground
  • space
  • events
  • max_distances
  • response_format? (might become too unmaintainable, but we'll see when we get to it)
  • metadata_filters

This can wait for the 0.10.0 release since I don't think there's time to make it into 0.9.0. This may change though...

@dchaddock dchaddock added the enhancement New feature or request label Jan 7, 2022
@dchaddock dchaddock added this to the v0.10.0 milestone Jan 7, 2022
@dchaddock
Copy link
Contributor Author

When we do this, we'll want to keep the current types allowed (ie. List[Dict] for ground) to keep backwards compatibility.

@dchaddock dchaddock removed this from the v0.10.0 milestone Jul 25, 2022
@dchaddock dchaddock added this to the 1.0.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant