Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate single-file script to hermetic python #21

Open
chiphogg opened this issue Nov 30, 2022 · 0 comments
Open

Migrate single-file script to hermetic python #21

chiphogg opened this issue Nov 30, 2022 · 0 comments
Labels
⬇️ affects: repo or tools Affects the non-library tools or the repository itself 📁 kind: cleanup Making the library nicer in some way, without affecting functionality much or at all 💪 effort: medium

Comments

@chiphogg
Copy link
Contributor

When I wrote make-single-file, I didn't realize we were going to be getting a hermetic python version. We should migrate the script implementation to a proper python rule which uses the hermetic python we have. The script itself should change to bash, and become a thin wrapper around a bazel call, as we do for clang-format.
@chiphogg chiphogg mentioned this issue Nov 30, 2022
Merged
@chiphogg chiphogg added the 📁 kind: cleanup Making the library nicer in some way, without affecting functionality much or at all label Dec 1, 2022
@chiphogg chiphogg mentioned this issue Dec 13, 2022
Merged
2 tasks
@chiphogg chiphogg added ⬇️ affects: repo or tools Affects the non-library tools or the repository itself 💪 effort: medium labels Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⬇️ affects: repo or tools Affects the non-library tools or the repository itself 📁 kind: cleanup Making the library nicer in some way, without affecting functionality much or at all 💪 effort: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chiphogg