-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building demo-kendo issues #22
Comments
|
I'd put a breakpoint here: https://github.com/aurelia-ui-toolkits/aurelia-kendoui-bridge/blob/master/sample/src/samples/index.js#L17 And see what routes are configured (compare working ones with the pivotgrid ones) It's probably an error in the json that drives the catalog, i just don't see it. https://github.com/aurelia-ui-toolkits/aurelia-kendoui-samples/blob/gh-pages/samples.json There must be something off with respect to the pivotgrid |
That is precisely the place I started debugging :-) While I have l leaarned more about the Aurelia's Router (wanted to go back from the point of the crash
I realized at that point that the solution of this problem should not need any debugging - it is enough to compare the request https://github.com/aurelia-ui-toolkits/demo-kendo/blob/master/src/catalog-index/controls.html#L61 with the definition of that sample - https://github.com/aurelia-ui-toolkits/aurelia-kendoui-samples/blob/gh-pages/samples.json#L18 'pivotgrid' versus 'pivot-grid' 😄 I will update the definition of that sample of course - after I have my lunch |
Thanks! Nice find :) |
1.I fixed the file samples.json - "PivotGrid": "pivot-grid",) is the correct spelling for that item. This results with the correct function of http://aurelia-ui-toolkits.github.io/demo-kendo/#/samples/pivot-grid-basic-use (pivot grid selected via Components Catalog -> Data Management -> PivotGrid toolbar activation without having to change the Catalog app itself (of course - as this was bug in app's data maintained separately). 2.In addition, there is the need to fix the catalog app as well because of this line. 3.Next, I found the inconsistency between the original code and the deployed app shown below meaning that you must have made this fix locally and did not update the repo. 4.There are two seemingly identical files in aurelia-kendoui-samples repo: Is I would prefer to update the catalog app only after I see your comments to these 4. issues |
|
Thanks for your feedback. I will deploy the catalog, no sweat 😄 |
Following my response to @Rhistina ☝️ November 16, 2017 4:13 PM:
A long list of deprecation warnings (see the next section ) - using
Running
gulp watch
, the app crashesApp crashes here
The text was updated successfully, but these errors were encountered: