Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results Page styling #69

Open
wbshaw opened this issue Oct 21, 2023 · 3 comments
Open

Results Page styling #69

wbshaw opened this issue Oct 21, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@wbshaw
Copy link

wbshaw commented Oct 21, 2023

Not so much of an issue, just a styling query.
Is there any reason for the 15em/25em Padding on all the "boks" divs - just adds huge gaps between sections and doesn't look tidy,
Can't see any reason for it, but sure there probably is.

e.g.:

get_stats.js
114 > 117
//INTRODUCTION function load_introduction() { var text = ""; text += "<div class='boks' data-color='red' style='width: 100%; padding-bottom: 15em; padding-top: 15em; height:auto; background-color:none'>";

833
text += "<div class='boks' data-color='pistach' style='height: auto !important; width: 100%; padding-bottom: 25em; padding-top: 25em; height:10em; background-color: none;'>";

@aunefyren
Copy link
Owner

The purpose is to provide a more "full-screen" effect to each section and to let the color fade while scrolling. You feel it would be better to have a more compact page?

@aunefyren aunefyren added the enhancement New feature or request label Oct 22, 2023
@wbshaw
Copy link
Author

wbshaw commented Oct 23, 2023

It's not too bad on mobile and flows ok, but on desktop it just feels like quite a big gap between sections, it's almost a full screen of space between each section and a lot of scrolling. I'm no designer though, so this is purely my opinion and I'm sure others may feel different.

@PhilipPetkov96
Copy link

I agree, I even added a scroll down message because initially It wasn't clear there is more on the page. Maybe arrows on the right side scrolling sections will be a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants