Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File name become the url path #2

Closed
airtonzanon opened this issue Sep 4, 2019 · 3 comments
Closed

File name become the url path #2

airtonzanon opened this issue Sep 4, 2019 · 3 comments
Assignees
@augustohp
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@airtonzanon
Copy link

airtonzanon commented Sep 4, 2019 •
edited
Loading

When I'm installing the script with sinister, the name becomes fjhO5

Example:

$ sh <(curl -sSL http://git.io/sinister) --local --chmod 755 --url https://git.io/fjhO5
fjhO5 was installed successfully

I saw that sinister has the parameter --name, but it didn't work well.

So just used mv

sh <(curl -sSL http://git.io/sinister) --local --chmod 755 --url https://git.io/fjhO5 && mv ~/bin/fjhO5 ~/bin/ship

But it will not be sustainable hehe.
augustohp added a commit to augustohp/sinister that referenced this issue Sep 5, 2019
@augustohp
Prefer --name when a URL is provided
28f7e3c 
Since https://git.io doesn't support custom URLs anymore, this workflow
becomes more necessary. Spotted on augustohp/ship#2.
@augustohp augustohp added the bug Something isn't working label Sep 5, 2019
@augustohp augustohp self-assigned this Sep 5, 2019
@augustohp augustohp added this to the 1.0.0 milestone Sep 5, 2019
@augustohp
Copy link
Owner

augustohp commented Sep 5, 2019 •
edited
Loading

Thanks a lot for testing and creating the bug! I am terribly sorry that I didn't test that workflow before writing it on the README. There is an upstream problem I am waiting to be fixed, if it doesn't get merged by the end of the week I will fork and start using my fork for installation.

augustohp added a commit that referenced this issue Sep 5, 2019
@augustohp
Renames the script to ship after installation
a95eabc 
Sinister prefers the URI resource name which, in this case, is a short
name. Passing the `--name` parameters should work but there is a bug on
jamesqo/sinister#5 that prefers the *URI resource name* rather than the
parameters given - which means this waits the upstream merge to be
merged.

Closes #2
@augustohp augustohp mentioned this issue Sep 5, 2019
Closed
augustohp added a commit that referenced this issue Sep 5, 2019
@augustohp
Hotfixes script name on installation
2afe02b 
Sinister prefers the URI resource name which, in this case, is a short
name. Passing the --name parameters should work but there is a bug on
jamesqo/sinister#5 that prefers the URI resource name rather than the
parameters given - which means this waits the upstream merge to be
merged.

This commit uses the hotfix for this situation while upstream isn't
merged or accepted.

Related to #2
@augustohp augustohp mentioned this issue Sep 5, 2019
Merged
augustohp added a commit that referenced this issue Sep 5, 2019
@augustohp
Hotfixes script name on installation
29e07cd 
Sinister prefers the URI resource name which, in this case, is a short
name. Passing the --name parameters should work but there is a bug on
jamesqo/sinister#5 that prefers the URI resource name rather than the
parameters given - which means this waits the upstream merge to be
merged.

This commit uses the hotfix for this situation while upstream isn't
merged or accepted.

Related to #2
@augustohp
Copy link
Owner

augustohp commented Sep 5, 2019 •
edited
Loading

🛠 Installation instructions should be fixed now. I will close this issue if upstream gets merged or 1 week passes from now. 😉

Thanks again for reporting. Let me know if you miss anything or if it was useful.

augustohp added a commit that referenced this issue Sep 5, 2019
@augustohp
Renames the script to ship after installation
f382999 
Sinister prefers the URI resource name which, in this case, is a short
name. Passing the `--name` parameters should work but there is a bug on
jamesqo/sinister#5 that prefers the *URI resource name* rather than the
parameters given - which means this waits the upstream merge to be
merged.

Closes #2
augustohp added a commit that referenced this issue Sep 5, 2019
@augustohp
Renames the script to ship after installation
fac1a9d 
Sinister prefers the URI resource name which, in this case, is a short
name. Passing the `--name` parameters should work but there is a bug on
jamesqo/sinister#5 that prefers the *URI resource name* rather than the
parameters given - which means this waits the upstream merge to be
merged.

Closes #2
@augustohp
Copy link
Owner

I am closing this, there is the possibility that upstream merge will take a little while (or never happen). Thank you for reporting! 🙇

I would note that, although not solved in the upstream, the issue is resolved in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@augustohp augustohp

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Renames the script to ship after installation augustohp/ship
2 participants
@augustohp @airtonzanon