separate style and inline_height settings for ctrl+r and up keybinding

[gwenya]

I would really like to have the "full" style taking up the complete window when I press ctrl+r, but the "compact" style and only 10 lines or so when using the up arrow.

If creating such a feature wouldn't require huge rewrites then I would love to try implementing it, and would appreciate some pointers about where to start with that.

[ellie]

That sounds cool to me! I don't think it will need much of a rewrite at all, here are a few pointers

For a summary of what's probably needed

1. Our shell integrations pass a different flag for the up arrow

atuin/crates/atuin/src/shell/atuin.zsh

Line 84 in 4b758aa

_atuin_search --shell-up-key-binding "$@"

Which is defined here

atuin/crates/atuin/src/command/client/search.rs

Lines 76 to 77 in 4b758aa

	#[arg(long = "shell-up-key-binding", hide = true)]
	shell_up_key_binding: bool,

2. We have a search setting struct defined here, which would be a sensible place to apply some config

atuin/crates/atuin-client/src/settings.rs

Lines 374 to 376 in 4b758aa

	pub struct Search {
	/// The list of enabled filter modes, in order of priority.
	pub filters: Vec<FilterMode>,

I don't have a strong preference on config naming

3. Finally, the inline_height value is used here

atuin/crates/atuin/src/command/client/search/interactive.rs

Lines 1025 to 1043 in 4b758aa

	pub async fn history(
	query: &[String],
	settings: &Settings,
	mut db: impl Database,
	history_store: &HistoryStore,
	theme: &Theme,
	) -> Result<String> {
	let stdout = Stdout::new(settings.inline_height > 0)?;
	let backend = CrosstermBackend::new(stdout);
	let mut terminal = Terminal::with_options(
	backend,
	TerminalOptions {
	viewport: if settings.inline_height > 0 {
	Viewport::Inline(settings.inline_height)
	} else {
	Viewport::Fullscreen
	},
	},
	)?;

This has access to the settings struct. We'll probably want some way of passing the flag through, but I'll leave that up to you.

Let me know if you need any help!