Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to enable/disable module #1

Open
LinuxJedi opened this issue Jun 22, 2015 · 1 comment
Open

Add way to enable/disable module #1

LinuxJedi opened this issue Jun 22, 2015 · 1 comment

Comments

@LinuxJedi
Copy link

Hi,

It appears the module implements some mutexes which will in-general reduce the performance of Nginx. I understand that these exist because the alternative would be an IPC interface to the workers for which there is no hook.

I recommend you add a way to turn this module on/off, maybe even dynamically, so that data is only captured and mutexes are used when data needs to be captured.

@erikdubbelboer
Copy link
Contributor

I just pushed a version to this branch: a001bd9 that has this feature. Is this something that would work for you?

When the module is disabled the overhead for each request is only the additional handler call plus one atomic variable lookup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants