Skip to content

Commit a63c74b

Browse files
authored
Merge pull request #186 from atomic-state/fixes/FetchConfig
FIX(defaults):
2 parents 86c71f6 + 20735e8 commit a63c74b

File tree

3 files changed

+13
-37
lines changed

3 files changed

+13
-37
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "http-react",
3-
"version": "3.5.3",
3+
"version": "3.5.4",
44
"description": "React hooks for data fetching",
55
"main": "dist/index.js",
66
"scripts": {

src/components/FetchConfigAsync.tsx

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,11 @@ export async function FetchConfigAsync(props: FetchContextType) {
2323

2424
const $data = $value.data ?? $value
2525

26-
if (!isDefined(valuesMemory.get(resolvedKey))) {
27-
valuesMemory.set(resolvedKey, $data)
28-
}
29-
if (!isDefined(fetcherDefaults.get(resolvedKey))) {
30-
fetcherDefaults.set(resolvedKey, $data)
31-
}
26+
valuesMemory.set(resolvedKey, $data)
3227

33-
if (!isDefined(cacheProvider.get(resolvedKey))) {
34-
cacheProvider.set(resolvedKey, $data)
35-
}
28+
fetcherDefaults.set(resolvedKey, $data)
29+
30+
cacheProvider.set(resolvedKey, $data)
3631
}
3732

3833
for (let defaultKey in defaults) {
@@ -42,15 +37,8 @@ export async function FetchConfigAsync(props: FetchContextType) {
4237
})
4338

4439
if (isDefined(id)) {
45-
if (!isDefined(valuesMemory.get(resolvedKey))) {
46-
valuesMemory.set(resolvedKey, await defaults[defaultKey]?.value)
47-
}
48-
if (!isDefined(fetcherDefaults.get(resolvedKey))) {
49-
fetcherDefaults.set(resolvedKey, await defaults[defaultKey]?.value)
50-
}
51-
}
52-
53-
if (!isDefined(cacheProvider.get(resolvedKey))) {
40+
valuesMemory.set(resolvedKey, await defaults[defaultKey]?.value)
41+
fetcherDefaults.set(resolvedKey, await defaults[defaultKey]?.value)
5442
cacheProvider.set(resolvedKey, await defaults[defaultKey]?.value)
5543
}
5644
}

src/components/index.tsx

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,11 @@ export function FetchConfig(props: FetchContextType) {
7777
parsedChunk = dataChunk
7878
}
7979

80-
if (!isDefined(valuesMemory.get(resolvedKey))) {
81-
valuesMemory.set(resolvedKey, parsedChunk)
82-
}
83-
if (!isDefined(fetcherDefaults.get(resolvedKey))) {
84-
fetcherDefaults.set(resolvedKey, parsedChunk)
85-
}
80+
valuesMemory.set(resolvedKey, parsedChunk)
8681

87-
if (!isDefined(cacheProvider.get(resolvedKey))) {
88-
cacheProvider.set(resolvedKey, parsedChunk)
89-
}
82+
fetcherDefaults.set(resolvedKey, parsedChunk)
83+
84+
cacheProvider.set(resolvedKey, parsedChunk)
9085
}
9186

9287
for (let defaultKey in defaults) {
@@ -96,15 +91,8 @@ export function FetchConfig(props: FetchContextType) {
9691
})
9792

9893
if (isDefined(id)) {
99-
if (!isDefined(valuesMemory.get(resolvedKey))) {
100-
valuesMemory.set(resolvedKey, defaults[defaultKey]?.value)
101-
}
102-
if (!isDefined(fetcherDefaults.get(resolvedKey))) {
103-
fetcherDefaults.set(resolvedKey, defaults[defaultKey]?.value)
104-
}
105-
}
106-
107-
if (!isDefined(cacheProvider.get(resolvedKey))) {
94+
valuesMemory.set(resolvedKey, defaults[defaultKey]?.value)
95+
fetcherDefaults.set(resolvedKey, defaults[defaultKey]?.value)
10896
cacheProvider.set(resolvedKey, defaults[defaultKey]?.value)
10997
}
11098
}

0 commit comments

Comments
 (0)