Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text completions #18

Closed
aminya opened this issue Jul 28, 2020 · 6 comments
Closed

Fix text completions #18

aminya opened this issue Jul 28, 2020 · 6 comments

Comments

@aminya
Copy link
Member

aminya commented Jul 28, 2020

We should start with this: atom/atom-languageclient#254

@UziTech
Copy link
Member

UziTech commented Jul 28, 2020

When I looked into copying that PR to this repo it looks like most of the code has already been updated. I'm not sure how to rebase that PR onto the changes that have happened since it was opened.

@jonboiser
Copy link

A similar bug was reported downstream in the ide-python library.

https://github.com/atom-community/ide-python/issues/251

I was able to isolate it to the change here made in #100. When I revert the change on my local copy of ide-python's dependencies, it fixes the issue. So there might be some interaction between the two issues.

@aminya
Copy link
Member Author

aminya commented Jan 5, 2021

A similar bug was reported downstream in the ide-python library.

atom-community/ide-python#251

I was able to isolate it to the change here made in #100. When I revert the change on my local copy of ide-python's dependencies, it fixes the issue. So there might be some interaction between the two issues.

Thanks for the report. I transferred the issue.

@aminya
Copy link
Member Author

aminya commented Jan 6, 2021

Sometimes when I press TAB nothing gets written by autocomplete.

@UziTech
Copy link
Member

UziTech commented Jan 6, 2021

Sometimes when I press TAB nothing gets written by autocomplete.

That seems like an issue for the autocomplete package.

@UziTech
Copy link
Member

UziTech commented Jan 6, 2021

I'm pretty sure test completions are fixed in v1.0.6

If there are still issues create another issue with specific details.

@UziTech UziTech closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants