Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports in Links and Nodes are dicts, not Port objects #95

Closed
sajith opened this issue Jun 22, 2023 · 2 comments · Fixed by #152
Closed

Ports in Links and Nodes are dicts, not Port objects #95

sajith opened this issue Jun 22, 2023 · 2 comments · Fixed by #152
Assignees
Labels
enhancement New feature or request in_progress

Comments

@sajith
Copy link
Member

sajith commented Jun 22, 2023

These lines in LinkHandler look right:


Also these lines in NodeHandler:


@sajith sajith self-assigned this Jun 22, 2023
@sajith
Copy link
Member Author

sajith commented Aug 18, 2023

It is probably better to leave this alone for now, until we have made some progress on #92. The discussion on atlanticwave-sdx/sdx-controller#190 also is relevant.

In the interim, when implementing L2VPN pieces in pce, I think we can make do with Ports encoded-as-dicts.

@YufengXin
Copy link
Collaborator

node.set_ports() returns the Port objects because it call port_handler(), while link.set_ports() returns dict,
-> node.ports (Port) and link.ports (dict).

As a reminder when make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in_progress
Projects
Development

Successfully merging a pull request may close this issue.

2 participants