-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link that has a port with no label range #108
Comments
This may be a (intentional or unintentional) mistake.(1) It may be interpreted as 'all vlans' are available'; or (2) an error. Otherwise, it would prevent your code find a vlan assignment along a path, right? |
Yes, this makes VLAN assignment a little more tricky. I am leaning towards treating this as an error, unless we have a reason to interpret it otherwise. |
Sure. Then please add a vlan range to this port so your code can work. |
After thinking about this a little more, I think not adding a |
Of the three main static topology files, there's a link that has one port that has no
label_range
:datamodel/src/sdx_datamodel/data/topologies/zaoxi.json
Lines 16 to 21 in 1a6404a
I think this is the only such one. Should this be treated like an error? If so, I believe schema should be updated accordingly, and error handling should be updated accordingly.
The text was updated successfully, but these errors were encountered: