Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link that has a port with no label range #108

Open
sajith opened this issue Aug 24, 2023 · 4 comments
Open

Link that has a port with no label range #108

sajith opened this issue Aug 24, 2023 · 4 comments

Comments

@sajith
Copy link
Member

sajith commented Aug 24, 2023

Of the three main static topology files, there's a link that has one port that has no label_range:

{
"id": "urn:ogf:network:sdx:port:zaoxi:B1:2",
"name": "Novi01:2",
"node": "urn:ogf:network:sdx:node:zaoxi:B1",
"status": "up"
},

I think this is the only such one. Should this be treated like an error? If so, I believe schema should be updated accordingly, and error handling should be updated accordingly.

@YufengXin
Copy link
Collaborator

This may be a (intentional or unintentional) mistake.(1) It may be interpreted as 'all vlans' are available'; or (2) an error. Otherwise, it would prevent your code find a vlan assignment along a path, right?

@sajith
Copy link
Member Author

sajith commented Aug 24, 2023

Yes, this makes VLAN assignment a little more tricky. I am leaning towards treating this as an error, unless we have a reason to interpret it otherwise.

@YufengXin
Copy link
Collaborator

Sure. Then please add a vlan range to this port so your code can work.
Later, in practice, let's see how the real topology from OXPs would show up.

@sajith
Copy link
Member Author

sajith commented Aug 24, 2023

After thinking about this a little more, I think not adding a label_range here makes sense, at least for now. Because of this particular missing label_range, an error case was surfaced in pce, and by handling that we're able to make pce a little more robust (I hope!). We can't assume perfectly well-formed topology data, at least until we have stricter validation in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants