-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSONAPI standard #10
Comments
I agree @gschorkopf, but imagine that would require a significant refactor? I just made a PR #15 that addresses annoying things about conforming to that standard for error messages. That makes me thing we'll end up doing more work to conform to it than the refactoring to just use jsonapi-resources would be. You have experience here so would love your opinion on whether reworking to use https://github.com/cerebris/jsonapi-resources is a worthwhile endeavor. |
It wouldn't be significant if we nip it in the bud now now. Error messaging is pretty simple in JSONAPI land. Honestly, the main thing is: we're Ember devs. I know it'll require pain the the short term, but believe it's worth it if we actually want to build a product that is truly "convention over configuration" ala Rails/Ember. Plus, jsonapi-resources is a jam, and makes life super simple for the API. I'm on vacation. Will try to address this more later. |
@gschorkopf completely agree. Better to move now while we have very little to migrate over. |
AFAIK this repository uses REST, and not the jsonapi.org standard. Am I wrong? Should we consider moving in this direction? I feel like https://github.com/cerebris/jsonapi-resources is the gold standard here.
The text was updated successfully, but these errors were encountered: