Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player sizing control #124

Open
jbenet opened this issue May 11, 2013 · 0 comments
Open

player sizing control #124

jbenet opened this issue May 11, 2013 · 0 comments

Comments

@jbenet
Copy link
Member

jbenet commented May 11, 2013

Right now, player sizing is a mess.

content-view, splash-view, editor-view have heights defined in css, that are then overridden elsewhere (acorn website/player.html).

The desired scenario is that clients should only specify height on acorn-player, and the player should figure everything else itself.

This is of course tricky with things like the editor, or long form text, which could potentially take up a lot of height on the page (if desired). So clients should be able to omit height (maybe only specifying min-height), and player should resize its height accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant