Skip to content

Commit 6df913d

Browse files
committed
Cleanup: Fix formatting and typos (mostly in comments)
1 parent 3d9a322 commit 6df913d

File tree

196 files changed

+1357
-1358
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

196 files changed

+1357
-1358
lines changed

ChangeLog

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ to the server from the audio thread.
271271

272272
The BME-700 Glide on/off switch was not active.
273273

274-
Roadrunner Vibrato was too deep, by a long way. Scaled back the tremelo at the
274+
Roadrunner Vibrato was too deep, by a long way. Scaled back the tremolo at the
275275
same time. Gentle vibrato was still possible but not under mouse control, it
276276
had to be done with keyboard accel/deccel.
277277

@@ -1846,7 +1846,7 @@ to force the save settings into the active set.
18461846
The Polysix emulation would clip excessively with the modgroup was routed
18471847
fully to the VCA. The signal gain from the LFO would result in an overdriven
18481848
output. Reduced all the respective output stage signal levels, which are still
1849-
quite strong anyway, and also some of the tremelo depth when mod routed. This
1849+
quite strong anyway, and also some of the tremolo depth when mod routed. This
18501850
will have a minor effect on some patches.
18511851

18521852
Incorporated Andrew Coughlan's manual page for the Polysix emulator.

README

Lines changed: 186 additions & 186 deletions
Large diffs are not rendered by default.

bin/bristoljackstats.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ bristolJackTest()
6060
}
6161

6262
/*
63-
* This should go out as the first release with Jack. After that the interface
64-
* will change - at the moment Jack subsumes Bristol, and this is the wrong
63+
* This should go out as the first release with JACK. After that the interface
64+
* will change - at the moment JACK subsumes Bristol, and this is the wrong
6565
* way around. The audiomain structure is buried inside the jack structure,
6666
* but I would prefer the contrary. In addition, with it the contrary then
6767
* it would be easier to integrate alternative distribution drivers (DSSI).
@@ -77,7 +77,7 @@ main(int argc, char *argv[])
7777
// printf("%s: connect to jackd to find samplerate and period size\n",
7878
// argv[0]);
7979

80-
/* I don't want all the output from jack, redirect it */
80+
/* I don't want all the output from JACK, redirect it */
8181
outfd = dup(STDOUT_FILENO);
8282
nullfd = open("/dev/null", O_WRONLY);
8383
dup2(nullfd, STDOUT_FILENO);
@@ -92,7 +92,7 @@ main(int argc, char *argv[])
9292

9393
return(0);
9494
#else
95-
printf("This should connect to jack but it does not appear to be compiled\n");
95+
printf("This should connect to JACK but it does not appear to be compiled\n");
9696
return(-2);
9797
#endif /* _BRISTOL_JACK */
9898

brighton/brighton.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ main(int argc, char **argv)
923923
sysid &= 0x7f7f7f7f;
924924
bristolMidiOption(0, BRISTOL_NRP_SYSID_H, sysid >> 16);
925925
bristolMidiOption(0, BRISTOL_NRP_SYSID_L, sysid & 0x0000ffff);
926-
printf("fixing sysex system id at 0x%x\n", sysid);
926+
printf("fixing SysEx system id at 0x%x\n", sysid);
927927
}
928928
}
929929

@@ -1016,7 +1016,7 @@ main(int argc, char **argv)
10161016
}
10171017

10181018
if (global.synths->flags & REQ_DEBUG_MASK)
1019-
printf("debuging level set to %i\n",
1019+
printf("debugging level set to %i\n",
10201020
(global.synths->flags&REQ_DEBUG_MASK)>>12);
10211021
}
10221022

@@ -1598,10 +1598,10 @@ main(int argc, char **argv)
15981598
/*
15991599
* We play around with the names here so that the window title gets filled
16001600
* with more information than just the emulator name. This enhancement was
1601-
* added for JSM but could be any Jack installation. If multiple instances
1601+
* added for JSM but could be any JACK installation. If multiple instances
16021602
* of the same emulator are started then it is not clear which is which:
16031603
* both have the same title bar but different names in Jack. What we do here
1604-
* is add the Jack registration name to the title bar.
1604+
* is add the JACK registration name to the title bar.
16051605
*/
16061606
snprintf(appname, 64, "%s (%s)",
16071607
synthesisers[global.synths->synthtype]->name, devname);
@@ -1857,7 +1857,7 @@ eventMgr()
18571857
if ((midiHandle = bristolMidiOpen("brighton",
18581858
BRISTOL_CONN_SEQ|BRISTOL_RDONLY,
18591859
-1, -1, brightonMidiInput, &global)) < 0)
1860-
printf("Error opening midi device %s\n", "0.0");
1860+
printf("Error opening MIDI device %s\n", "0.0");
18611861
}
18621862
}
18631863

@@ -1870,7 +1870,7 @@ eventMgr()
18701870
midiFD = bristolGetMidiFD(midiHandle);
18711871
cFD = bristolGetMidiFD(global.controlfd);
18721872

1873-
printf("opened GUI midi handles: %i, %i\n", midiFD, cFD);
1873+
printf("opened GUI MIDI handles: %i, %i\n", midiFD, cFD);
18741874

18751875
/*
18761876
if (global.libtest != 1)
@@ -1942,7 +1942,7 @@ eventMgr()
19421942
if (r == BRISTOL_MIDI_CHANNEL)
19431943
{
19441944
if ((global.synths->flags & REQ_DEBUG_MASK) >= REQ_DEBUG_4)
1945-
printf("Read failed on Midi FD\n");
1945+
printf("Read failed on MIDI FD\n");
19461946
global.flags |= REQ_EXIT;
19471947

19481948
pthread_exit(0);
@@ -1967,7 +1967,7 @@ eventMgr()
19671967
* We should have some 'tack' in here where we call a routine in the
19681968
* library that will execute any timed events that have been requested,
19691969
* this will cover things like flashing lights, VU metering. It will
1970-
* also be used to cover the midi sequencer.
1970+
* also be used to cover the MIDI sequencer.
19711971
*
19721972
* We should also attempt to recover lost time in graphical processing
19731973
* by changing mwt into a target sleep period by getting the current

brighton/brightonArp2600.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -876,20 +876,20 @@ arp2600MidiCallback(brightonWindow *win, int command, int value, float v)
876876
{
877877
guiSynth *synth = findSynth(global.synths, win);
878878

879-
printf("midi callback: %x, %i\n", command, value);
879+
printf("MIDI callback: %x, %i\n", command, value);
880880

881881
switch(command)
882882
{
883883
case MIDI_PROGRAM:
884-
printf("midi program: %x, %i\n", command, value);
884+
printf("MIDI program: %x, %i\n", command, value);
885885
synth->location = value;
886886

887887
arp2600LoadMemory(synth, "arp2600", 0,
888888
synth->location, synth->mem.active, 0, 0);
889889

890890
break;
891891
case MIDI_BANK_SELECT:
892-
printf("midi banksel: %x, %i\n", command, value);
892+
printf("MIDI banksel: %x, %i\n", command, value);
893893
synth->bank = value;
894894
break;
895895
}
@@ -999,10 +999,10 @@ arp2600Midi(guiSynth *synth, int fd, int chan, int c, int o, int v)
999999
/*
10001000
* To overcome that we should consider checking a sequence number in
10011001
* the message library? That is non trivial since it requires that
1002-
* our midi messges have a 'ack' flag included - we cannot check for
1002+
* our MIDI messages have a 'ack' flag included - we cannot check for
10031003
* ack here (actually, we could, and in the app is probably the right
10041004
* place to do it rather than the lib however both would have to be
1005-
* changed to suppor this - nc).
1005+
* changed to support this - nc).
10061006
*/
10071007
bristolMidiSendMsg(global.controlfd, synth->sid,
10081008
127, 0, BRISTOL_MIDICHANNEL|newchan);
@@ -1101,7 +1101,7 @@ arp2600IOSelect(guiSynth *synth, int fd, int chan, int c, int o, int v)
11011101
* can be removed.
11021102
*
11031103
* The structure we need should have an input and output list, this should
1104-
* give the true co-ords for the start and endpoint since it will be used
1104+
* give the true coords for the start and endpoint since it will be used
11051105
* to evaluate the transforms for the patch source to the on-screen dest
11061106
* bitmaps.
11071107
*

brighton/brightonAxxe.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -579,18 +579,18 @@ midiCallback(brightonWindow *win, int controller, int value, float n)
579579
{
580580
guiSynth *synth = findSynth(global.synths, win);
581581

582-
printf("midi callback: %x, %i\n", controller, value);
582+
printf("MIDI callback: %x, %i\n", controller, value);
583583

584584
switch(controller)
585585
{
586586
case MIDI_PROGRAM:
587-
printf("midi program: %x, %i\n", controller, value);
587+
printf("MIDI program: %x, %i\n", controller, value);
588588
synth->location = value;
589589
loadMemory(synth, synth->resources->name, 0,
590590
synth->location, synth->mem.active, 0, 0);
591591
break;
592592
case MIDI_BANK_SELECT:
593-
printf("midi banksel: %x, %i\n", controller, value);
593+
printf("MIDI banksel: %x, %i\n", controller, value);
594594
synth->bank = value * 10;
595595

596596
synth->location = (synth->location % 10) + value * 10;
@@ -718,10 +718,10 @@ axxeMidi(guiSynth *synth, int fd, int chan, int c, int o, int v)
718718
#warning if we do not check for ack then socket might hang on exit
719719
* To overcome that we should consider checking a sequence number in
720720
* the message library? That is non trivial since it requires that
721-
* our midi messges have a 'ack' flag included - we cannot check for
721+
* our MIDI messages have a 'ack' flag included - we cannot check for
722722
* ack here (actually, we could, and in the app is probably the right
723723
* place to do it rather than the lib however both would have to be
724-
* changed to suppor this - nc).
724+
* changed to support this - nc).
725725
*/
726726
bristolMidiSendMsg(global.controlfd, synth->sid,
727727
127, 0, BRISTOL_MIDICHANNEL|newchan);

brighton/brightonBME700.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ brightonLocations bme700mods[MODS_COUNT] = {
294294
"bitmaps/buttons/touchnlR.xpm", BRIGHTON_CHECKBUTTON},
295295

296296
/*
297-
* UP/DOWN was memory but could be midi channel. Withdrawn for now since I want to keep
297+
* UP/DOWN was memory but could be MIDI channel. Withdrawn for now since I want to keep
298298
* this panel uncluttered
299299
*/
300300
{"", 2, 590, 700, 100, 100, 0, 1, 0, "bitmaps/buttons/touchnlg.xpm",
@@ -467,9 +467,9 @@ brightonApp bme700App = {
467467
};
468468

469469
/*
470-
* We really want to just use one midi channel and let the midi library decide
470+
* We really want to just use one MIDI channel and let the MIDI library decide
471471
* that we have multiple synths on the channel with their own split points.
472-
* The lower layer should define the midi channel, split point and transpose
472+
* The lower layer should define the MIDI channel, split point and transpose
473473
* of upper layer.
474474
*/
475475
static int
@@ -555,14 +555,14 @@ midiCallback(brightonWindow *win, int controller, int value, float n)
555555
* We should accept 0..74 as lower layer and above that as dual
556556
* loading requests.
557557
*/
558-
printf("midi program: %x, %i\n", controller, value);
558+
printf("MIDI program: %x, %i\n", controller, value);
559559
synth->location = value;
560560
loadMemory(synth, SYNTH_NAME, 0, synth->bank + synth->location,
561561
OPTS_START, 0, BRISTOL_FORCE);
562562
optsShim(synth);
563563
break;
564564
case MIDI_BANK_SELECT:
565-
printf("midi banksel: %x, %i\n", controller, value);
565+
printf("MIDI banksel: %x, %i\n", controller, value);
566566
synth->bank = value;
567567
synth->location = value;
568568
loadMemory(synth, SYNTH_NAME, 0, synth->bank + synth->location,
@@ -615,7 +615,7 @@ printf("%i %i\n", synth->bank, synth->location);
615615
case 7:
616616
case 8:
617617
/*
618-
* Radiobutton memory selectors, doubleclick should load
618+
* Radiobutton memory selectors, double-click should load
619619
*/
620620
if (synth->dispatch[ACTIVE_DEVS].other1 != -1)
621621
{
@@ -641,7 +641,7 @@ printf("%i %i\n", synth->bank, synth->location);
641641
break;
642642
case 9:
643643
/*
644-
* Save on doubleclick
644+
* Save on double-click
645645
*/
646646
if (brightonDoubleClick(dc) != 0)
647647
saveMemory(synth, SYNTH_NAME, 0, synth->bank + synth->location, 0);

brighton/brightonBassMaker.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
*
2929
* Global transpose. Test.
3030
* Mem search DONE
31-
* Midi channel DONE
31+
* MIDI channel DONE
3232
* Need to make sure transpose and channel selections are in the memories and
3333
* recovered. Tested ctype, cc, transpose
3434
*
@@ -43,7 +43,7 @@
4343
* Copy page
4444
* Fill values
4545
*
46-
* Midi send and recieve clock. ffs.
46+
* MIDI send and receive clock. ffs.
4747
*/
4848

4949
#include <fcntl.h>
@@ -74,7 +74,7 @@ static int dc;
7474
#define STEP_COUNT (PAGE_STEP * PAGE_COUNT)
7575

7676
#define TOTAL_DEVS (PAGE_STEP * OP_COUNT)
77-
#define CONTROL_COUNT 60 /* controls less memomry selectors/entry */
77+
#define CONTROL_COUNT 60 /* controls less memory selectors/entry */
7878
#define CONTROL_ACTIVE 20
7979
#define COFF (TOTAL_DEVS * PAGE_COUNT)
8080
#define ACTIVE_DEVS (COFF + CONTROL_ACTIVE)
@@ -555,19 +555,19 @@ bmMidiCallback(brightonWindow *win, int controller, int value, float n)
555555
{
556556
guiSynth *synth = findSynth(global.synths, win);
557557

558-
printf("midi callback: %x, %i\n", controller, value);
558+
printf("MIDI callback: %x, %i\n", controller, value);
559559

560560
switch(controller)
561561
{
562562
case MIDI_PROGRAM:
563-
printf("midi program: %x, %i\n", controller, value);
563+
printf("MIDI program: %x, %i\n", controller, value);
564564
synth->bank = value - (value % 8);
565565
synth->location = value % 8;
566566
loadMemory(synth, "bassmaker", 0, synth->bank * 10 + synth->location,
567567
synth->mem.active, 0, 0);
568568
break;
569569
/*
570-
* This needs a case statement for midi clock which can then be used
570+
* This needs a case statement for MIDI clock which can then be used
571571
* to drive the fast timers.
572572
*/
573573
}
@@ -582,7 +582,7 @@ brightonApp bmApp = {
582582
"bassmaker",
583583
0,
584584
"bitmaps/textures/metal2.xpm",
585-
BRIGHTON_STRETCH|BRIGHTON_REVERSE, /* default is tesselate */
585+
BRIGHTON_STRETCH|BRIGHTON_REVERSE, /* default is tessellate */
586586
bmInit,
587587
bmConfigure, /* 3 callbacks, unused? */
588588
bmMidiCallback,
@@ -1119,7 +1119,7 @@ bmSendControl(guiSynth *synth, bmMem *bm, int c, int o)
11191119
int note, chan, velocity;
11201120

11211121
/*
1122-
* Convert the setting into 12 steps, take cc to be midi channel
1122+
* Convert the setting into 12 steps, take cc to be MIDI channel
11231123
* Channel is the 'cc' setting here.
11241124
*/
11251125
if ((chan = bm->control.cc) > 15)
@@ -1283,7 +1283,7 @@ bmCallLed(guiSynth *synth, int fd, int chan, int c, int o, int v)
12831283
BRISTOL_EVENT_KEYOFF, note, velocity);
12841284
break;
12851285
case 1:
1286-
/* Dont' send note off */
1286+
/* Don't send note off */
12871287
if (v)
12881288
{
12891289
bmSendControl(synth, bm, c, o);
@@ -1292,7 +1292,7 @@ bmCallLed(guiSynth *synth, int fd, int chan, int c, int o, int v)
12921292
}
12931293
break;
12941294
case 2:
1295-
/* Dont' send note on, only off */
1295+
/* Don't send note on, only off */
12961296
bristolMidiSendKeyMsg(global.controlfd, synth->midichannel,
12971297
BRISTOL_EVENT_KEYOFF, note, velocity);
12981298
return;

0 commit comments

Comments
 (0)