Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-bindgen feature to README/docs #64

Open
qdot opened this issue Jan 25, 2021 · 3 comments
Open

Add wasm-bindgen feature to README/docs #64

qdot opened this issue Jan 25, 2021 · 3 comments

Comments

@qdot
Copy link

qdot commented Jan 25, 2021

Just found out there's a wasm-bindgen feature via the PR then reading the Cargo.toml. Would be nice to have this in the README.

@najamelan
Copy link

Wouldn't it be better to automatically turn these dependencies on on wasm? AFAICT the library can't work on wasm without them. It would save users from having to fiddle with feature flags.

@qdot
Copy link
Author

qdot commented May 31, 2021

Sure, that'd work too.

@dariusc93
Copy link

Wouldn't it be better to automatically turn these dependencies on on wasm? AFAICT the library can't work on wasm without them. It would save users from having to fiddle with feature flags.

I agree that it would be better to have it enabled based on the target, especially since it doesnt fail to build on non-wasm32 targets, it makes it hard to debug the time not implemented on this platform panic message when Instant or SystemTime is used from std due to Instant being used by the native module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants